fix delayed display of top bar in chat after sending messages #18300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibrkhalil
approved these changes
Dec 26, 2023
Jenkins BuildsClick to see older builds (25)
|
58% of end-end tests have passedNot executed tests (1)Failed tests (16)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Expected to fail tests (4)Click to expandClass TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (28)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
Class TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
79% of end-end tests have passedFailed tests (6)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (4)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Passed tests (38)Click to expandClass TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePR:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
|
|
@Parveshdhull Hi! I am facing this #18240 issue on Android and iOS. Android: Please, have a look on my video. Top bar appears only as you can see from my third "Hi" message . When i send my first 2 messages Avatar hides partly and it looks not good I suppose. video_2023-12-29_15-28-14.mp4iOS: Please, have a look on my video. Top bar appears only as you can see from my second "H" message . When i send my first message Avatar hides partly and it looks not good I suppose. IMG_5859.MP4 |
According to design description when designing this animation, They wanted to show the small name once the big name is not visible, And they shouldn't both be visible at the same time. |
Parveshdhull
force-pushed
the
fix/delayed-topbar
branch
from
0cc215d
to
e3e0f23
Compare
|
hi @mariia-skrypnyk, Android Issue: This was an interesting edge case. When we closed the keyboard by scrolling (instead of the back button) both the About the Android/IOS issue top nav appearing after 2/3 of messages is expected. As @ibrkhalil, mentioned according to the design team top nav should be visible once the big avatar is hidden and both should not be visible at the same time. (like in ios case, a big avatar is still visible a little) |
79% of end-end tests have passedFailed tests (6)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (4)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (38)Click to expandClass TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
|
Thanks for your comment @ibrkhalil . I just have a small question regarding the behaviour you described above. |
|
@Parveshdhull I've found such an issue on your latest PR build. Please have a look on my description below. ISSUE 1: [Android] Profile avatar quickly moves to the left while user closes keyboard. Screen.Recording.2024-01-03.at.10.58.07.movvideo_2024-01-03_11-10-15.mp4 |
alwx
approved these changes
Jan 3, 2024
Parveshdhull
force-pushed
the
fix/delayed-topbar
branch
from
e3e0f23
to
ab2a147
Compare
|
hi @mariia-skrypnyk, Thank you for finding these issues.
I am not sure which one is correct behavior, as we don't have any animations for this situation. Only have this old video which don't work anymore. About another issue, jumping of top-bar in left. It looks this one is also in develop. Will it be ok if I fix this one separately? |
65% of end-end tests have passedFailed tests (13)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Expected to fail tests (4)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Passed tests (31)Click to expandClass TestActivityMultipleDevicePR:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePRTwo:
Class TestDeepLinksOneDevice:
|
Thanks! I am going to test your fix with the name case. |
Parveshdhull
force-pushed
the
fix/delayed-topbar
branch
from
ab2a147
to
aada7e5
Compare
|
hi, no new changes. Just rebased the PR. |
|
fixed a small issue in ios where the big avatar is sometime not shown when the chat screen is opened 
|
Parveshdhull
force-pushed
the
fix/delayed-topbar
branch
2 times, most recently
from
d9f80b2
to
9d1e54d
Compare
|
Hi @Parveshdhull ! Androids looks much better! Great Thanks! ISSUE 2: [iOS] User see no profile picture in 1to1 chat top bar after sending his second message Steps:
Actual result: User see no profile (big or small) at the top bar Expected result: as we do not see big profile name at this case we should see the small one. Such case works great on Android PR build Tested on: |
|
hi @mariia-skrypnyk, Thank you for finding this issue. Should be fixed now. |
Thanks @Parveshdhull! Tested on: |
Parveshdhull
force-pushed
the
fix/delayed-topbar
branch
from
48ffa73
to
1901c04
Compare
briansztamfater
pushed a commit
that referenced
this pull request
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #18240
status: ready