Wallet: crypto max decimals #18267
Merged
Wallet: crypto max decimals #18267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmarBasem
force-pushed
the
wallet/max-decimals
branch
from
f3a4a88
to
06656e1
Compare
OmarBasem
requested review from
shivekkhurana,
vkjr,
briansztamfater,
smohamedjavid,
J-Son89,
mmilad75 and
ulisesmac
Jenkins BuildsClick to see older builds (30)
|
J-Son89
reviewed
Dec 21, 2023
| @@ -0,0 +1,18 @@ | |||
| (ns status-im.contexts.wallet.common.utils-test | |||
smohamedjavid
approved these changes
Dec 21, 2023
75% of end-end tests have passedNot executed tests (1)Failed tests (6)Click to expandClass TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (6)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Passed tests (36)Click to expandClass TestActivityMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestDeepLinksOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityMultipleDeviceMerged:
|
J-Son89
approved these changes
Dec 21, 2023
J-Son89
reviewed
Dec 21, 2023
| @@ -36,6 +36,31 @@ | |||
| (map (comp :raw-balance val)) | |||
| (reduce money/add))) | |||
|
|
|||
| (defn extract-exponent | |||
| [s] | |||
| (if-let [index (string/index-of s "e")] | |||
There was a problem hiding this comment.
nit:
"e" is related to euler's number? maybe we put it in a def
e.g (def eulers-number "e")
There was a problem hiding this comment.
@J-Son89 "e" is exponent in a number, i.e, 0.1234774e-7. We are extracting the number after the exponent.
J-Son89
approved these changes
Dec 21, 2023
OmarBasem
force-pushed
the
wallet/max-decimals
branch
from
15e3538
to
787b0af
Compare
|
Hi @OmarBasem, thanks for the PR! Could you take a look and confirm that decimals are displayed correctly for tokens when the token dollar amount is zero? PR video_2023-12-22_17-05-53.mp4Develop 
|
100% of end-end tests have passedPassed tests (14)Click to expandClass TestActivityMultipleDevicePRTwo:
Class TestActivityMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
qoqobolo
approved these changes
Jan 3, 2024
|
Thanks for the fixes and waiting @OmarBasem ! |
OmarBasem
force-pushed
the
wallet/max-decimals
branch
from
ac0df08
to
a7b0668
Compare
✔️ status-mobile/prs/android/PR-18267#12 🔹 ~7 min 26 sec 🔹 a7b0668 🔹 📦 android package |
✔️ status-mobile/prs/android/PR-18267#13 🔹 ~7 min 10 sec 🔹 e7346b6 🔹 📦 android package |
OmarBasem
force-pushed
the
wallet/max-decimals
branch
from
d395fe2
to
1f36e11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #18244
This PR implements max possible decimals for crypto values.
Before:
After:
