-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add internal-link component for #17116 #18109
Conversation
Jenkins BuildsClick to see older builds (105)
|
Can we have a GH issue for adding this component? 🙏 |
Thank you very much for the review Jamie, Sorry it's been months since I worked on a quo component and forgot the guidelines. |
src/quo/components/links/internal_link_card/community/view.cljs
Outdated
Show resolved
Hide resolved
src/quo/components/links/internal_link_card/community/view.cljs
Outdated
Show resolved
Hide resolved
src/quo/components/links/internal_link_card/community/view.cljs
Outdated
Show resolved
Hide resolved
src/quo/components/links/internal_link_card/community/view.cljs
Outdated
Show resolved
Hide resolved
src/status_im2/contexts/quo_preview/links/internal_link_card_community.cljs
Outdated
Show resolved
Hide resolved
src/quo/components/links/internal_link_card/community/view.cljs
Outdated
Show resolved
Hide resolved
src/quo/components/links/internal_link_card/community/component_spec.cljs
Outdated
Show resolved
Hide resolved
Done |
60% of end-end tests have passed
Failed tests (15)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Expected to fail tests (4)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (29)Click to expandClass TestCommunityOneDeviceMerged:
Class TestDeepLinksOneDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
|
@ibrkhalil Hi! Thanks for your PR. I've installed both for the iOS and Android and did these steps but see no frame on mobile as designed:
|
Apologies for not saying that this is the UI component only, I shouldn't have asked for QA for review as the implementation is better to be in a followup. |
@ibrkhalil please, rebase your PR, launch tests one more time and then it is read for design review, I suppose. |
46% of end-end tests have passed
Failed tests (22)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePRTwo:
Expected to fail tests (4)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Passed tests (22)Click to expandClass TestDeepLinksOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
|
Needed for #17961, #18200
Figma frame: https://www.figma.com/file/WQZcp6S0EnzxdTL4taoKDv/Design-System-for-Mobile?type=design&node-id=11182-147560&mode=design&t=YiBxTJfSltWP9JhM-0
status: ready