Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: no avatar for the first message in 1-1 chat #18099

Merged
merged 6 commits into from
Dec 11, 2023
Merged

fix: no avatar for the first message in 1-1 chat #18099

merged 6 commits into from
Dec 11, 2023

Conversation

codemaster115
Copy link
Contributor

fixes #17345

Summary

Fix the first messages sent after accepting contact request do not contain avatar

Platforms

  • Android
  • iOS

Areas that maybe impacted

Functional
  • 1-1 chats

Steps to test

  1. User1: send contact request
  2. User2: accept contact request
  3. User2: send message

status: ready

@codemaster115 codemaster115 self-assigned this Dec 6, 2023
@codemaster115 codemaster115 linked an issue Dec 6, 2023 that may be closed by this pull request
No user avatar is shown for the first messages in 1-1 chat after accepting contact request #17345
Closed
@status-im-auto
Copy link
Member

status-im-auto commented Dec 6, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (24)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 42793e5 #1 2023-12-06 16:18:05 ~6 min android-e2e 🤖apk 📲
✔️ 42793e5 #1 2023-12-06 16:21:41 ~10 min android 🤖apk 📲
✔️ 42793e5 #1 2023-12-06 16:27:42 ~16 min tests 📄log
✔️ 42793e5 #1 2023-12-06 16:28:02 ~16 min ios 📱ipa 📲
✔️ 66d8b95 #3 2023-12-06 16:39:14 ~6 min android-e2e 🤖apk 📲
✔️ 66d8b95 #3 2023-12-06 16:40:03 ~7 min android 🤖apk 📲
✔️ 66d8b95 #3 2023-12-06 16:46:55 ~14 min ios 📱ipa 📲
✔️ c55aac2 #4 2023-12-06 16:58:21 ~6 min android-e2e 🤖apk 📲
✔️ c55aac2 #4 2023-12-06 16:58:34 ~6 min android 🤖apk 📲
✔️ c55aac2 #4 2023-12-06 16:58:49 ~6 min ios 📱ipa 📲
✔️ c55aac2 #4 2023-12-06 17:03:41 ~11 min tests 📄log
✔️ b2d57d6 #5 2023-12-06 17:19:40 ~6 min ios 📱ipa 📲
✔️ b2d57d6 #5 2023-12-06 17:23:33 ~10 min android-e2e 🤖apk 📲
✔️ b2d57d6 #5 2023-12-06 17:23:59 ~10 min android 🤖apk 📲
✔️ b2d57d6 #5 2023-12-06 17:25:31 ~12 min tests 📄log
✔️ 8153937 #6 2023-12-06 18:08:41 ~6 min ios 📱ipa 📲
✔️ 8153937 #6 2023-12-06 18:08:54 ~6 min android-e2e 🤖apk 📲
✔️ 8153937 #6 2023-12-06 18:09:11 ~6 min android 🤖apk 📲
✔️ 8153937 #6 2023-12-06 18:12:34 ~10 min tests 📄log
✔️ bdfaa94 #7 2023-12-06 18:23:39 ~6 min android 🤖apk 📲
✔️ bdfaa94 #7 2023-12-06 18:26:18 ~8 min android-e2e 🤖apk 📲
✔️ bdfaa94 #7 2023-12-06 18:28:17 ~10 min tests 📄log
✔️ bdfaa94 #7 2023-12-06 18:29:03 ~11 min ios 📱ipa 📲
✔️ bdfaa94 #8 2023-12-11 18:13:22 ~6 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 617b175 #8 2023-12-11 20:01:56 ~2 min tests 📄log
❌ 84a7847 #9 2023-12-11 20:08:49 ~4 min tests 📄log
✔️ 84a7847 #10 2023-12-11 20:10:08 ~5 min ios 📱ipa 📲
✔️ 84a7847 #9 2023-12-11 20:11:09 ~6 min android-e2e 🤖apk 📲
✔️ 84a7847 #10 2023-12-11 20:12:45 ~2 min tests 📄log
✔️ 84a7847 #9 2023-12-11 20:12:58 ~8 min android 🤖apk 📲

@codemaster115 codemaster115 force-pushed the 17345-no-user-avatar-is-shown-for-the-first-messages-in-1-1-chat-after-accepting-contact-request branch from 8b1d236 to 66d8b95 Compare December 6, 2023 16:32
@codemaster115 codemaster115 force-pushed the 17345-no-user-avatar-is-shown-for-the-first-messages-in-1-1-chat-after-accepting-contact-request branch from 8153937 to bdfaa94 Compare December 6, 2023 18:17
@status-im-auto
Copy link
Member

73% of end-end tests have passed

Total executed tests: 48
Failed tests: 6
Expected to fail tests: 7
Passed tests: 35
Not executed tests: 1

IDs of not executed tests: 704615 

IDs of failed tests: 704613,702957,703297,702786,702958,703629 

IDs of expected to fail tests: 702732,702948,702894,703503,702846,702731,702808

Not executed tests (1)

Click to expand
  • Rerun not executed tests

    • Failed tests (6)

    Click to expand
  • Rerun failed tests

    • Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613

    Device 1: Find `Button` by `xpath`: `//*[@text="open community"]`
    Device 1: Tap on found: Button 

    critical/test_deep_and_universal_links.py:56: in test_links_open_universal_links_from_chat
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Closed community was not requested to join by the url https://status.app/c/G8EAAGTiXKuwNbVVAu0GNLD-XzX4oz_E8oC1-7qSLikaTnCuG9Ag13ZgQKrMd8En9Qcpuaj3Qx3mfZ1atZzH8Zw-x_sFJ_MDv0P_7YfqoV-pNr3V4dsza-jVk41GaCGWasJb92Oer8qggaoNWf0tYCgSH19VonXciKPUz3ITdgke#zQ3shbmfT3hvh4mKa1v6uAjjyztQEroh8Mfn6Ckegjd7LT3XK



    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_mentions_push_notification, id: 702786

    Device 2: Getting PN by 'user_2'
    Device 2: Looking for a message by text: user_2 

    critical/chats/test_public_chat_browsing.py:902: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Edited message is not shown correctly for the sender
E    Edited message is not shown correctly for the (receiver) admin



    Device sessions

    2. test_community_join_when_node_owner_offline, id: 703629

    Device 2: Tap on found: Button
    Device 2: Looking for community: 'open community' 

    critical/chats/test_public_chat_browsing.py:1115: in test_community_join_when_node_owner_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Joined status is not displayed
E    open community is not listed inside Joined communities tab



    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957

    Device 2: Find Button by xpath: //*[@content-desc='password-input']/../following-sibling::*//*[@text='Join Community']
    Device 2: Tap on found: Button 

    Test setup failed: activity_center/test_activity_center.py:397: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:433: in join_community
    self.community_status_joined.wait_for_visibility_of_element(60)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958 

    Test setup failed: activity_center/test_activity_center.py:397: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:433: in join_community
    self.community_status_joined.wait_for_visibility_of_element(60)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element



    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_send_image_save_and_share, id: 703297

    # STEP: Admin checks image message
    Device 1: Looking for a message by text: test image 

    critical/chats/test_group_chat.py:223: in test_group_chat_send_image_save_and_share
    self.chats[0].chat_element_by_text(image_description).wait_for_visibility_of_element(60)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 1: ChatElementByText by xpath:`//*[starts-with(@text,'test image')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    Expected to fail tests (7)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    2. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member 

    critical/chats/test_group_chat.py:323: in test_group_chat_offline_pn
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Messages PN was not fetched from offline

    [[Data delivery issue]]

    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    2. test_community_navigate_to_channel_when_relaunch, id: 702846 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Issue #18075]]

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_hashtag_links_to_community_channels, id: 702948

    Device 2: Find Text by xpath: //android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'#cats')]
    Device 2: Looking for a message by text: it is just a message text 

    critical/chats/test_public_chat_browsing.py:1048: in test_community_hashtag_links_to_community_channels
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Receiver was not navigated to the cats channel
E    Sender was not navigated to the cats channel

    [[Can't navigate to a channel by hashtag link, https://github.com//issues/18095]]

    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_contact_block_unblock_offline, id: 702894

    Device 1: Find ProfileSendMessageButton by accessibility id: Chat-item-button
    Device 1: Sending message 'piy' 

    critical/chats/test_public_chat_browsing.py:741: in test_community_contact_block_unblock_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Chat with unblocked user was not enabled after 1 minute

    [[Message can be missed after unblock: https://github.com//issues/16873]]

    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Passed tests (35)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495
    Device sessions

    2. test_group_chat_reactions, id: 703202
    Device sessions

    3. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_leave, id: 702845
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_other_apps, id: 704614
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_message_delete, id: 702839
    Device sessions

    6. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    7. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    8. test_community_message_edit, id: 702843
    Device sessions

    9. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    @churik churik self-assigned this Dec 11, 2023
    @churik
    Copy link
    Member

    churik commented Dec 11, 2023

    @codemaster115
    thank you for your work!! PR is ready to be merged

    @codemaster115 codemaster115 force-pushed the 17345-no-user-avatar-is-shown-for-the-first-messages-in-1-1-chat-after-accepting-contact-request branch from bdfaa94 to 617b175 Compare December 11, 2023 19:59
    @codemaster115 codemaster115 merged commit fc8590a into develop Dec 11, 2023
    6 checks passed
    @codemaster115 codemaster115 deleted the 17345-no-user-avatar-is-shown-for-the-first-messages-in-1-1-chat-after-accepting-contact-request branch December 11, 2023 20:13
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @cammellos cammellos cammellos approved these changes

    @flexsurfer flexsurfer Awaiting requested review from flexsurfer

    @J-Son89 J-Son89 Awaiting requested review from J-Son89

    Assignees

    @churik churik

    @codemaster115 codemaster115

    Labels
    bug request-manual-qa Tested - OK
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    No user avatar is shown for the first messages in 1-1 chat after accepting contact request
    4 participants
    @codemaster115 @status-im-auto @churik @cammellos