Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: finish enable notifications #18084

Merged
merged 7 commits into from
Dec 12, 2023
Merged

feat: finish enable notifications #18084

merged 7 commits into from
Dec 12, 2023

Conversation

BalogunofAfrica
Copy link
Contributor

fixes #17506

Summary

This PR implements the enable notifications screen as seen in the design feedback here: https://www.figma.com/file/Tf5nfkYvpbnNCo4rKLK7lS/Feedback-for-Mobile?type=design&node-id=6117-67315&mode=design&t=DAsT60Sje05FrhhM-0#569642792

Platforms

  • Android
  • iOS

status: ready

@status-im-auto
Copy link
Member

status-im-auto commented Dec 6, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (20)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 91bf52b #1 2023-12-06 03:52:24 ~2 min tests 📄log
✔️ 91bf52b #1 2023-12-06 03:55:33 ~6 min android 🤖apk 📲
✔️ 91bf52b #1 2023-12-06 03:55:40 ~6 min android-e2e 🤖apk 📲
✔️ 91bf52b #1 2023-12-06 04:05:26 ~16 min ios 📱ipa 📲
❌ b56e8b2 #3 2023-12-06 04:15:28 ~3 min tests 📄log
✔️ b56e8b2 #3 2023-12-06 04:18:37 ~6 min android 🤖apk 📲
✔️ b56e8b2 #3 2023-12-06 04:18:49 ~6 min android-e2e 🤖apk 📲
✔️ b56e8b2 #3 2023-12-06 04:27:36 ~15 min ios 📱ipa 📲
❌ 730f57f #4 2023-12-06 21:52:55 ~2 min tests 📄log
✔️ 730f57f #4 2023-12-06 21:56:19 ~6 min android-e2e 🤖apk 📲
✔️ 730f57f #4 2023-12-06 21:56:35 ~6 min android 🤖apk 📲
✔️ 730f57f #4 2023-12-06 21:57:21 ~7 min ios 📱ipa 📲
✔️ 06da9ff #5 2023-12-08 09:47:32 ~6 min android-e2e 🤖apk 📲
✔️ 06da9ff #5 2023-12-08 09:47:52 ~6 min android 🤖apk 📲
✔️ 06da9ff #5 2023-12-08 09:49:37 ~8 min ios 📱ipa 📲
❌ 06da9ff #5 2023-12-08 09:56:59 ~15 min tests 📄log
❌ 4316259 #6 2023-12-12 11:28:23 ~2 min tests 📄log
✔️ 4316259 #6 2023-12-12 11:32:20 ~6 min ios 📱ipa 📲
✔️ 4316259 #6 2023-12-12 11:34:03 ~7 min android-e2e 🤖apk 📲
✔️ 4316259 #6 2023-12-12 11:34:16 ~8 min android 🤖apk 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ e48aff4 #7 2023-12-12 12:06:27 ~4 min tests 📄log
✔️ e48aff4 #7 2023-12-12 12:08:26 ~6 min android-e2e 🤖apk 📲
✔️ e48aff4 #7 2023-12-12 12:08:26 ~6 min ios 📱ipa 📲
✔️ e48aff4 #7 2023-12-12 12:10:00 ~8 min android 🤖apk 📲
✔️ e48aff4 #8 2023-12-12 12:20:43 ~2 min tests 📄log
✔️ 8b5883a #9 2023-12-12 12:42:15 ~5 min tests 📄log
✔️ 8b5883a #8 2023-12-12 12:42:53 ~6 min ios 📱ipa 📲
✔️ 8b5883a #8 2023-12-12 12:45:36 ~9 min android 🤖apk 📲
✔️ 8b5883a #8 2023-12-12 12:45:36 ~9 min android-e2e 🤖apk 📲

@BalogunofAfrica BalogunofAfrica self-assigned this Dec 6, 2023
@BalogunofAfrica BalogunofAfrica force-pushed the feat/finish-enable-notifications branch 2 times, most recently from 0176537 to b56e8b2 Compare December 6, 2023 04:11
J-Son89
J-Son89 reviewed Dec 6, 2023
View reviewed changes
src/status_im2/contexts/onboarding/enable_notifications/view.cljs
[parallax/video
{:layers (:notifications resources/parallax-video)
:stretch stretch}]))

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra line

J-Son89
J-Son89 reviewed Dec 6, 2023
View reviewed changes
src/status_im2/navigation/screens.cljs
@@ -207,7 +207,7 @@
:animations (merge transitions/new-to-status-modal-animations
transitions/push-animations-for-transparent-background)
:modalPresentationStyle :overCurrentContext}
:component enable-notifications/enable-notifications}
:component enable-notifications/view}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@J-Son89
Copy link
Contributor

J-Son89 commented Dec 6, 2023

I tested this and looks good 👌 - admittedly the app did crash on the onboarding process but on the "welcome" page and I couldn't reproduce this afterwards, only happened once out of a few trys

Francesca-G
Francesca-G approved these changes Dec 6, 2023
View reviewed changes
Copy link

@Francesca-G Francesca-G left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great ✨

ajayesivan
ajayesivan approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@ajayesivan ajayesivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🎉

@pavloburykh pavloburykh self-assigned this Dec 8, 2023
@status-im-auto
Copy link
Member

82% of end-end tests have passed

Total executed tests: 49
Failed tests: 2
Expected to fail tests: 7
Passed tests: 40

IDs of failed tests: 702936,702947 

IDs of expected to fail tests: 702732,702948,702894,703503,702846,702731,702808

Failed tests (2)

Click to expand
  • Rerun failed tests

    • Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936

    Device 2: Tap on found: Button
    Device 2: Attempt 0 is successful clicking close-activity-center 

    Test setup failed: /home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:703: in urlopen
    httplib_response = self._make_request(
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:449: in _make_request
    six.raise_from(e, None)
<string>:3: in raise_from
    ???
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:444: in _make_request
    httplib_response = conn.getresponse()
/usr/lib/python3.10/http/client.py:1375: in getresponse
    response.begin()
/usr/lib/python3.10/http/client.py:318: in begin
    version, status, reason = self._read_status()
/usr/lib/python3.10/http/client.py:287: in _read_status
    raise RemoteDisconnected("Remote end closed connection without"
E   http.client.RemoteDisconnected: Remote end closed connection without response

During handling of the above exception, another exception occurred:
activity_center/test_activity_center.py:224: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:156: in wait_for_rendering_ended_and_click
    self.click()
../views/base_element.py:90: in click
    self.find_element().click()
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webelement.py:94: in click
    self._execute(Command.CLICK_ELEMENT)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webelement.py:395: in _execute
    return self._parent.execute(command, params)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:343: in execute
    response = self.command_executor.execute(driver_command, params)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/remote_connection.py:291: in execute
    return self._request(command_info[0], url, body=data)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/remote_connection.py:312: in _request
    response = self._conn.request(method, url, body=body, headers=headers)
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/request.py:78: in request
    return self.request_encode_body(
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/request.py:170: in request_encode_body
    return self.urlopen(method, url, **extra_kw)
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/poolmanager.py:376: in urlopen
    response = conn.urlopen(method, u.request_uri, **kw)
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:787: in urlopen
    retries = retries.increment(
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/util/retry.py:550: in increment
    raise six.reraise(type(error), error, _stacktrace)
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/packages/six.py:769: in reraise
    raise value.with_traceback(tb)
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:703: in urlopen
    httplib_response = self._make_request(
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:449: in _make_request
    six.raise_from(e, None)
<string>:3: in raise_from
    ???
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:444: in _make_request
    httplib_response = conn.getresponse()
/usr/lib/python3.10/http/client.py:1375: in getresponse
    response.begin()
/usr/lib/python3.10/http/client.py:318: in begin
    version, status, reason = self._read_status()
/usr/lib/python3.10/http/client.py:287: in _read_status
    raise RemoteDisconnected("Remote end closed connection without"
 ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response'))



    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947 

    Test setup failed: /home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:703: in urlopen
    httplib_response = self._make_request(
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:449: in _make_request
    six.raise_from(e, None)
<string>:3: in raise_from
    ???
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:444: in _make_request
    httplib_response = conn.getresponse()
/usr/lib/python3.10/http/client.py:1375: in getresponse
    response.begin()
/usr/lib/python3.10/http/client.py:318: in begin
    version, status, reason = self._read_status()
/usr/lib/python3.10/http/client.py:287: in _read_status
    raise RemoteDisconnected("Remote end closed connection without"
E   http.client.RemoteDisconnected: Remote end closed connection without response

During handling of the above exception, another exception occurred:
activity_center/test_activity_center.py:224: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:382: in handle_contact_request
    chat_element.accept_contact_request()
../views/home_view.py:150: in accept_contact_request
    self.handle_cr("accept-contact-request")
../views/home_view.py:147: in handle_cr
    ).wait_for_rendering_ended_and_click()
../views/base_element.py:156: in wait_for_rendering_ended_and_click
    self.click()
../views/base_element.py:90: in click
    self.find_element().click()
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webelement.py:94: in click
    self._execute(Command.CLICK_ELEMENT)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webelement.py:395: in _execute
    return self._parent.execute(command, params)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:343: in execute
    response = self.command_executor.execute(driver_command, params)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/remote_connection.py:291: in execute
    return self._request(command_info[0], url, body=data)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/remote_connection.py:312: in _request
    response = self._conn.request(method, url, body=body, headers=headers)
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/request.py:78: in request
    return self.request_encode_body(
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/request.py:170: in request_encode_body
    return self.urlopen(method, url, **extra_kw)
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/poolmanager.py:376: in urlopen
    response = conn.urlopen(method, u.request_uri, **kw)
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:787: in urlopen
    retries = retries.increment(
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/util/retry.py:550: in increment
    raise six.reraise(type(error), error, _stacktrace)
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/packages/six.py:769: in reraise
    raise value.with_traceback(tb)
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:703: in urlopen
    httplib_response = self._make_request(
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:449: in _make_request
    six.raise_from(e, None)
<string>:3: in raise_from
    ???
/home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:444: in _make_request
    httplib_response = conn.getresponse()
/usr/lib/python3.10/http/client.py:1375: in getresponse
    response.begin()
/usr/lib/python3.10/http/client.py:318: in begin
    version, status, reason = self._read_status()
/usr/lib/python3.10/http/client.py:287: in _read_status
    raise RemoteDisconnected("Remote end closed connection without"
 ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response'))



    Expected to fail tests (7)

    Click to expand

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_hashtag_links_to_community_channels, id: 702948

    Device 2: Find Text by xpath: //android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'#cats')]
    Device 2: Looking for a message by text: it is just a message text 

    critical/chats/test_public_chat_browsing.py:1079: in test_community_hashtag_links_to_community_channels
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Receiver was not navigated to the cats channel
E    Sender was not navigated to the cats channel

    [[Can't navigate to a channel by hashtag link, https://github.com//issues/18095]]

    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    2. test_community_navigate_to_channel_when_relaunch, id: 702846 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Issue #18075]]

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    2. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member 

    critical/chats/test_group_chat.py:323: in test_group_chat_offline_pn
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Messages PN was not fetched from offline

    [[Data delivery issue]]

    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_contact_block_unblock_offline, id: 702894

    Device 1: Find ProfileSendMessageButton by accessibility id: Chat-item-button
    Device 1: Sending message 'piy' 

    critical/chats/test_public_chat_browsing.py:742: in test_community_contact_block_unblock_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Chat with unblocked user was not enabled after 1 minute

    [[Message can be missed after unblock: https://github.com//issues/16873]]

    Device sessions

    Passed tests (40)

    Click to expand

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_mentions_push_notification, id: 702786
    Device sessions

    3. test_community_leave, id: 702845
    Device sessions

    4. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_open_universal_links_from_other_apps, id: 704614
    Device sessions

    3. test_links_deep_links, id: 702775
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    6. test_community_message_delete, id: 702839
    Device sessions

    7. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    9. test_community_message_edit, id: 702843
    Device sessions

    10. test_community_unread_messages_badge, id: 702841
    Device sessions

    @pavloburykh pavloburykh force-pushed the feat/finish-enable-notifications branch from 06da9ff to 4316259 Compare December 12, 2023 11:25
    @pavloburykh
    Copy link
    Contributor

    pavloburykh commented Dec 12, 2023 •
    edited by BalogunofAfrica
    Loading

    @BalogunofAfrica thank for the PR and sorry for delay with testing. No issues from my side. Ready for design review @Francesca-G

    @BalogunofAfrica
    Copy link
    Contributor Author

    @BalogunofAfrica thank for the PR and sorry for delay with testing. No issues from my side. Ready for design review @Francesca-G

    Thanks @pavloburykh @Francesca-G has already reviewed

    @pavloburykh
    Copy link
    Contributor

    @Francesca-G has already reviewed

    Great! Then we are ready for merge.

    @BalogunofAfrica BalogunofAfrica merged commit f1bcc62 into develop Dec 12, 2023
    6 checks passed
    @BalogunofAfrica BalogunofAfrica deleted the feat/finish-enable-notifications branch December 12, 2023 12:46
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @Francesca-G Francesca-G Francesca-G approved these changes

    @J-Son89 J-Son89 J-Son89 approved these changes

    @ajayesivan ajayesivan ajayesivan approved these changes

    @clauxx clauxx Awaiting requested review from clauxx

    @jo-mut jo-mut Awaiting requested review from jo-mut

    Assignees

    @BalogunofAfrica BalogunofAfrica

    @pavloburykh pavloburykh

    Labels
    request-manual-qa Tested - OK
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Finish the "Enable notifications" screen
    6 participants
    @BalogunofAfrica @status-im-auto @J-Son89 @pavloburykh @ajayesivan @Francesca-G