-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various fixes for the Information Box component #16272
Conversation
Jenkins BuildsClick to see older builds (8)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work 👍
18% of end-end tests have passed
Failed tests (27)Click to expandClass TestActivityMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Passed tests (6)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
|
2be5cc9
to
0745940
Compare
0745940
to
ae0f6ca
Compare
Fixes UI bugs described in #16271, and it also rewrites the component to follow our guidelines i.e. move code to style namespace, fix docstring, add component specs, move to separate quo2 directory, etc. This commit is part of the effort to fix the Community Overview screen.
Fixes UI bugs described in #16271, and it also rewrites the component to follow our guidelines i.e. move code to style namespace, fix docstring, add component specs, move to separate quo2 directory, etc. This commit is part of the effort to fix the Community Overview screen.
Fixes #16271
Summary
This PR fixes UI bugs described in #16271, and it also rewrites the component to follow our guidelines i.e. move code to
style
namespace, fix docstring, add component specs, move to separate quo2 directory, etc.I'm opening this PR as part of the effort to fix the Community Overview screen.
Before/after
Steps to test
Go to
Quo2 preview
>info
>information-box
status: ready