onboarding syncing updates #16206

jo-mut · 2023-06-06T16:09:40Z

Summary

Resolves the issues pointed out except illustrations and support camera flash functionality. Seems the camerakit library has some issues with flash as it does not seem to work on both android and ios

status-im-auto · 2023-06-06T16:13:25Z

Jenkins Builds

Click to see older builds (62)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`ffe736a`	#1	2023-06-06 16:13:25	~3 min	`tests`	📄`log`
✔️	`ffe736a`	#1	2023-06-06 16:16:28	~6 min	`android`	🤖`apk` 📲
✔️	`ffe736a`	#1	2023-06-06 16:16:30	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`ffe736a`	#1	2023-06-06 16:17:15	~7 min	`ios`	📱`ipa` 📲

✔️	`b04a694`	#3	2023-06-08 09:57:27	~7 min	`ios`	📱`ipa` 📲
❌	`b04a694`	#3	2023-06-08 10:09:21	~19 min	`tests`	📄`log`
✔️	`b04a694`	#3	2023-06-08 10:10:08	~20 min	`android-e2e`	🤖`apk` 📲
✔️	`b04a694`	#3	2023-06-08 10:10:37	~20 min	`android`	🤖`apk` 📲

✔️	`dd467a1`	#4	2023-06-08 10:52:41	~5 min	`android`	🤖`apk` 📲
✔️	`dd467a1`	#4	2023-06-08 10:52:54	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`dd467a1`	#4	2023-06-08 10:53:49	~6 min	`ios`	📱`ipa` 📲
✔️	`dd467a1`	#4	2023-06-08 10:55:04	~7 min	`tests`	📄`log`

✔️	`fbd7ae7`	#6	2023-06-09 12:46:22	~5 min	`android-e2e`	🤖`apk` 📲

✔️	`dd5a101`	#7	2023-06-09 12:53:10	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`dd5a101`	#7	2023-06-09 12:53:11	~5 min	`android`	🤖`apk` 📲
✔️	`dd5a101`	#7	2023-06-09 12:54:39	~7 min	`tests`	📄`log`
✔️	`dd5a101`	#7	2023-06-09 12:56:19	~8 min	`ios`	📱`ipa` 📲

✔️	`ceaf82d`	#8	2023-06-09 13:26:48	~6 min	`android`	🤖`apk` 📲
✔️	`ceaf82d`	#8	2023-06-09 13:26:50	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`ceaf82d`	#8	2023-06-09 13:26:56	~6 min	`ios`	📱`ipa` 📲
✔️	`ceaf82d`	#8	2023-06-09 13:27:33	~6 min	`tests`	📄`log`

✔️	`b97c208`	#9	2023-06-09 14:05:00	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`b97c208`	#9	2023-06-09 14:05:07	~5 min	`android`	🤖`apk` 📲
✔️	`b97c208`	#9	2023-06-09 14:06:15	~7 min	`ios`	📱`ipa` 📲
✔️	`b97c208`	#9	2023-06-09 14:08:30	~9 min	`tests`	📄`log`

✔️	`781c7c3`	#10	2023-06-10 19:01:10	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`781c7c3`	#10	2023-06-10 19:01:53	~6 min	`android`	🤖`apk` 📲
✔️	`781c7c3`	#10	2023-06-10 19:03:19	~7 min	`ios`	📱`ipa` 📲
✔️	`781c7c3`	#10	2023-06-10 19:04:04	~8 min	`tests`	📄`log`

✔️	`b0609c1`	#11	2023-06-12 08:39:44	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`b0609c1`	#11	2023-06-12 08:41:01	~6 min	`android`	🤖`apk` 📲
✔️	`b0609c1`	#11	2023-06-12 08:43:11	~8 min	`tests`	📄`log`
✔️	`b0609c1`	#11	2023-06-12 08:44:02	~9 min	`ios`	📱`ipa` 📲

✔️	`a58587a`	#12	2023-06-12 20:29:21	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`a58587a`	#12	2023-06-12 20:29:21	~5 min	`android`	🤖`apk` 📲
✔️	`a58587a`	#12	2023-06-12 20:30:11	~6 min	`ios`	📱`ipa` 📲
✔️	`a58587a`	#12	2023-06-12 20:30:55	~7 min	`tests`	📄`log`

✔️	`b4b8b69`	#13	2023-06-13 20:59:28	~5 min	`android`	🤖`apk` 📲
✔️	`b4b8b69`	#13	2023-06-13 20:59:51	~5 min	`ios`	📱`ipa` 📲
✔️	`b4b8b69`	#13	2023-06-13 21:00:30	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`b4b8b69`	#13	2023-06-13 21:02:29	~8 min	`tests`	📄`log`

✔️	`c18fb1c`	#14	2023-06-14 11:46:35	~5 min	`ios`	📱`ipa` 📲

✔️	`5d0467a`	#15	2023-06-14 11:53:14	~5 min	`ios`	📱`ipa` 📲
✔️	`5d0467a`	#15	2023-06-14 11:53:58	~6 min	`android`	🤖`apk` 📲
✔️	`5d0467a`	#15	2023-06-14 11:54:44	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`5d0467a`	#15	2023-06-14 11:58:22	~10 min	`tests`	📄`log`

✔️	`758761c`	#16	2023-06-14 13:17:39	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`758761c`	#16	2023-06-14 13:18:10	~6 min	`ios`	📱`ipa` 📲
✔️	`758761c`	#16	2023-06-14 13:18:49	~7 min	`android`	🤖`apk` 📲
✔️	`758761c`	#16	2023-06-14 13:19:44	~8 min	`tests`	📄`log`

✔️	`4ab5422`	#17	2023-06-14 18:19:18	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`4ab5422`	#17	2023-06-14 18:20:11	~6 min	`ios`	📱`ipa` 📲
✔️	`4ab5422`	#17	2023-06-14 18:20:48	~7 min	`android`	🤖`apk` 📲
✔️	`4ab5422`	#17	2023-06-14 18:22:14	~8 min	`tests`	📄`log`

✔️	`abaf01d`	#18	2023-06-14 22:35:40	~6 min	`ios`	📱`ipa` 📲
✔️	`abaf01d`	#18	2023-06-14 22:35:58	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`abaf01d`	#18	2023-06-14 22:36:04	~6 min	`android`	🤖`apk` 📲
✔️	`abaf01d`	#18	2023-06-14 22:37:21	~7 min	`tests`	📄`log`

✔️	`dbed7e8`	#19	2023-06-15 11:06:36	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`dbed7e8`	#19	2023-06-15 11:07:07	~7 min	`ios`	📱`ipa` 📲
✔️	`dbed7e8`	#19	2023-06-15 11:08:41	~9 min	`android`	🤖`apk` 📲
✔️	`dbed7e8`	#19	2023-06-15 11:11:42	~12 min	`tests`	📄`log`

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`f413502`	#20	2023-06-15 12:41:42	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`f413502`	#20	2023-06-15 12:41:46	~5 min	`android`	🤖`apk` 📲
✔️	`f413502`	#20	2023-06-15 12:42:10	~6 min	`ios`	📱`ipa` 📲
❌	`f413502`	#20	2023-06-15 12:46:42	~10 min	`tests`	📄`log`

✔️	`0795f91`	#21	2023-06-15 23:20:33	~6 min	`ios`	📱`ipa` 📲
✔️	`0795f91`	#21	2023-06-15 23:20:53	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`0795f91`	#21	2023-06-15 23:20:56	~6 min	`android`	🤖`apk` 📲
✔️	`0795f91`	#21	2023-06-15 23:21:58	~7 min	`tests`	📄`log`

ulisesmac · 2023-06-09T13:35:26Z

Hi @jo-mut

I was trying to review and contrast the changes, but it's being a little hard to know what exactly expect.
Could you please add some screenshots of the changed/implemented views and list what is being fixed?
Thank you in advance!

btw, this PR has the "fixes #..." but there're two remaining tasks in the issue, so I'd suggest to open new issues for those tasks or not closing this issue with this PR. wdyt?

Thanks again.

jo-mut · 2023-06-09T14:53:17Z

@ulisesmac I have added some screenshots to the p.r. As you might have seen some of the issues are not addressed in this pr. They can be addressed in a separate issue if the Q.A agrees with that and once the Q.A is okay with this pr it would then be fine to open a new issue.

There seems to be an issue with the camerakit as some of the camera features dont seems to work on both android and ios which is why they will better addressed in a separate issue as they have to do with the camerakit library we are using

ulisesmac · 2023-06-09T15:09:34Z

Thank you!

ulisesmac

Thanks for the PR! The screen has been improved! 💯

ulisesmac · 2023-06-09T15:26:47Z

src/status_im2/contexts/onboarding/sign_in/style.cljs

+   :border-style      :dashed
+   :border-width      1


How this change is showed?
I think this def (camera-permission-container) is not being used 🤔 inspecting a little more the code in this file, it seems like many defs are not being used, probably it's unrelated, but would you mind removing these unused vars if you are going to touch this file?

thanks!! :)

I guess I knew the answer to it.

A refactor happened last month (#15623) where the sign-in code has been moved to a common component (scan-sync-code) for making it easy to use from "Sign In" and "Add Device/Scan Sync Code" screens. But, the styles of sign-in haven't been removed. We can delete it.

ulisesmac · 2023-06-09T15:33:41Z

src/status_im2/contexts/syncing/scan_sync_code/view.cljs

+      [rn/view
+       {:style (style/qr-view-finder-container size)}
+       [rn/view
+        {:flex-direction :row :justify-content :space-between}


Please add these styles inside a :style key and move them to the style namespace

ulisesmac · 2023-06-09T15:59:34Z

src/status_im2/contexts/syncing/scan_sync_code/view.cljs

+         :type                :blur-bg
+         :size                32
+         :accessibility-label :camera-flash
+         :on-press            #()


If we are not going to use the on-press call back we could remove the key from the map, I think that's better than providing an empty function

smohamedjavid

Nice work! 🚀

smohamedjavid · 2023-06-09T16:59:05Z

src/status_im2/contexts/onboarding/sign_in/style.cljs

+   :border-style      :dashed
+   :border-width      1


I guess I knew the answer to it.

A refactor happened last month (#15623) where the sign-in code has been moved to a common component (scan-sync-code) for making it easy to use from "Sign In" and "Add Device/Scan Sync Code" screens. But, the styles of sign-in haven't been removed. We can delete it.

smohamedjavid · 2023-06-09T17:03:12Z

src/status_im2/contexts/syncing/scan_sync_code/view.cljs

@@ -142,21 +143,63 @@
 (defn- border
  [border1 border2 corner]
  [rn/view
-   (assoc {:border-color colors/white :width 80 :height 80} border1 2 border2 2 corner 16)])
+   (assoc style/border border1 2 border2 2 corner 16)])


Kindly move these styles as value to :style key.

jo-mut · 2023-06-14T12:23:20Z

@VladimrLitvinenko thank your observations. These issues are now resolved.

status-im-auto · 2023-06-14T15:01:26Z

76% of end-end tests have passed

Total executed tests: 33
Failed tests: 8
Passed tests: 25

IDs of failed tests: 702783,702841,702731,702855,702851,702732,702850,702894

Failed tests (8)

Click to expand

Rerun failed tests

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device 2: Find `Button` by `accessibility id`: `new-chat-button` Device 2: Find `Button` by `accessibility id`: `add-a-contact` medium/test_activity_center.py:78: in test_activity_center_contact_request_accept_swipe_mark_all_as_read self.home_2.add_contact(self.public_key_1, remove_from_contacts=True) ../views/home_view.py:337: in add_contact self.add_a_contact_chat_bottom_sheet_button.click() ../views/base_element.py:91: in click self.find_element().click() ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `add-a-contact` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_activity_center_contact_request_decline, id: 702850
Device 2: Looking for activity center element: 'sender' Device 2: Find `Button` by `xpath`: `//[contains(@text, 'sender')]/ancestor::[@content-desc='activity']//[@content-desc="activity-message-body"]` medium/test_activity_center.py:68: in test_activity_center_contact_request_decline if activity_center_element.message_body.text != self.home_2.get_translation_by_key("add-me-to-your-contacts"): ../views/base_element.py:209: in text return self.find_element().text ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 2: Button by xpath: `//[contains(@text, 'sender')]/ancestor::[@content-desc='activity']//[@content-desc="activity-message-body"]` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]

Class TestCommunityMultipleDeviceMerged:

1. test_community_unread_messages_badge, id: 702841
# STEP: Check new messages badge is shown for community Device 1: Click until `ChatMessageInput` by `accessibility id`: `chat-message-input` will be presented `critical/test_public_chat_browsing.py:682: in test_community_unread_messages_badge self.errors.verify_no_errors() base_test_case.py:182: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) New message community badge is not shown` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_community_contact_block_unblock_offline, id: 702894
Device 1: Looking for a message by text: Hurray! unblocked Device 1: Find `ChatElementByText` by `xpath`: `//[starts-with(@text,'Hurray! unblocked')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` critical/test_public_chat_browsing.py:742: in test_community_contact_block_unblock_offline chat_element.find_element() ../views/chat_view.py:134: in find_element self.wait_for_visibility_of_element(20) ../views/base_element.py:135: in wait_for_visibility_of_element raise TimeoutException( Device 1: ChatElementByText by xpath:`//[starts-with(@text,'Hurray! unblocked')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element; RemoteDisconnected Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
# STEP: Device1 goes back online and checks that 1-1 chat will be fetched Device 1: Looking for a message by text: test message `critical/chats/test_1_1_public_chats.py:1253: in test_1_1_chat_is_shown_message_sent_delivered_from_offline self.errors.verify_no_errors() base_test_case.py:182: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Message status was not delivered after back up online, it is "Sending"!` [[Issue with messages not being sent for a long time]] Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_1_1_chat_pin_messages, id: 702731
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]
3. test_1_1_chat_edit_message, id: 702855
Device 2: Find `Text` by `xpath`: `//[starts-with(@text,'Message before edit 1-1')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` Device 2: Tap on found: Text `critical/chats/test_1_1_public_chats.py:1142: in test_1_1_chat_edit_message self.chat_2.chat_element_by_text(message_before_edit_1_1).wait_for_status_to_be("Delivered") ../views/chat_view.py:228: in wait_for_status_to_be raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status)) Message status was not changed to Delivered, it's Sending` [[Message is being in status 'Sending' for a long time: https://github.com//issues/15385]]* Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Passed tests (25)

Click to expand

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_message_send_check_timestamps_sender_username, id: 702838
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_mentions_push_notification, id: 702786
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_offline_pn, id: 702808
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
2. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
3. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs

jo-mut · 2023-06-14T18:02:12Z

ios look

jo-mut · 2023-06-14T18:30:52Z

how it looks on android

status-im-auto · 2023-06-14T19:15:14Z

100% of end-end tests have passed

Total executed tests: 3
Failed tests: 0
Passed tests: 3

Passed tests (3)

Click to expand

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_contact_block_unblock_offline, id: 702894
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

VolodLytvynenko · 2023-06-14T19:45:25Z

how it looks on android

HI @jo-mut. Issue 1 is fixed. Issue 2 is reproduced for some devices. Reported it as a follow-up #16278 with low priority. Current PR can be merged. Thanx

jo-mut · 2023-06-15T10:57:45Z

@VladimrLitvinenko the issue addressed in this pr has three bugs that are not yet resolved

add flash option
This can be addressed in a follow-up pr as it needs this Upgrade react-native-camera-kit library to resolve camera issues in Sign In screen #16248 to be merged first. The underlying issue is the camarekit library. The issue will be tracked with this add camera flash mode option during syncing #16243

VolodLytvynenko · 2023-06-15T11:58:54Z

This can be addressed in a follow-up pr as it needs this

Hi, @jo-mut. Just to confirm, did I understand correctly that the current PR is waiting for the completion of #16248 before it can be retested and merged?

jo-mut · 2023-06-15T12:00:59Z

@VladimrLitvinenko no the current pr is fully done. I mean to say the remaining add flash to camera will be addressed in another pr. Just stating for the record but this is okay to merge

VolodLytvynenko · 2023-06-15T12:03:12Z

no the current pr is fully done. I mean to say the remaining add flash to camera will be addressed in another pr. Just stating for the record but this is okay to merge

Got it. Thank you for the clarification

Parveshdhull assigned jo-mut Jun 6, 2023

jo-mut force-pushed the bug/onboarding-sycing-updates branch 3 times, most recently from b04a694 to dd467a1 Compare June 8, 2023 10:47

jo-mut changed the title ~~[WIP] onboarding sycing updates~~ onboarding sycing updates Jun 8, 2023

jo-mut changed the title ~~onboarding sycing updates~~ onboarding syncing updates Jun 8, 2023

jo-mut changed the title ~~onboarding syncing updates~~ [WIP] onboarding syncing updates Jun 8, 2023

jo-mut force-pushed the bug/onboarding-sycing-updates branch 3 times, most recently from fbd7ae7 to dd5a101 Compare June 9, 2023 12:47

jo-mut requested review from J-Son89, smohamedjavid, flexsurfer, ilmotta, OmarBasem, ibrkhalil and ulisesmac June 9, 2023 12:49

jo-mut changed the title ~~[WIP] onboarding syncing updates~~ onboarding syncing updates Jun 9, 2023

jo-mut added the request-manual-qa label Jun 9, 2023

jo-mut force-pushed the bug/onboarding-sycing-updates branch from dd5a101 to ceaf82d Compare June 9, 2023 13:20

jo-mut force-pushed the bug/onboarding-sycing-updates branch from ceaf82d to b97c208 Compare June 9, 2023 13:58

ulisesmac approved these changes Jun 9, 2023

View reviewed changes

smohamedjavid approved these changes Jun 9, 2023

View reviewed changes

jo-mut force-pushed the bug/onboarding-sycing-updates branch 2 times, most recently from 781c7c3 to b0609c1 Compare June 12, 2023 08:34

ibrkhalil approved these changes Jun 14, 2023

View reviewed changes

jo-mut force-pushed the bug/onboarding-sycing-updates branch from 5d0467a to 758761c Compare June 14, 2023 13:11

VolodLytvynenko mentioned this pull request Jun 14, 2023

[Android] Horizontal frames are not centered within the camera box and a bulge appears at the end of the frame line #16278

Closed

jo-mut force-pushed the bug/onboarding-sycing-updates branch from 758761c to 4ab5422 Compare June 14, 2023 18:13

VolodLytvynenko added Tested - OK and removed Tested - Issues labels Jun 14, 2023

jo-mut force-pushed the bug/onboarding-sycing-updates branch from 4ab5422 to abaf01d Compare June 14, 2023 22:29

jo-mut force-pushed the bug/onboarding-sycing-updates branch from abaf01d to dbed7e8 Compare June 15, 2023 10:59

jo-mut force-pushed the bug/onboarding-sycing-updates branch from dbed7e8 to f413502 Compare June 15, 2023 12:35

jo-mut added 4 commits June 16, 2023 02:12

syncing screen updates

dc7d998

centered qr-view-finder border within the containing border

235e76e

rounded border tips

31a66ff

update icon color

0795f91

jo-mut force-pushed the bug/onboarding-sycing-updates branch from f413502 to 0795f91 Compare June 15, 2023 23:13

jo-mut merged commit a10c762 into develop Jun 15, 2023

jo-mut deleted the bug/onboarding-sycing-updates branch June 15, 2023 23:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

onboarding syncing updates #16206

onboarding syncing updates #16206

jo-mut commented Jun 6, 2023 •

edited

Loading

status-im-auto commented Jun 6, 2023 •

edited

Loading

ulisesmac commented Jun 9, 2023

jo-mut commented Jun 9, 2023 •

edited

Loading

ulisesmac commented Jun 9, 2023

ulisesmac left a comment

ulisesmac Jun 9, 2023

smohamedjavid Jun 9, 2023

ulisesmac Jun 9, 2023

ulisesmac Jun 9, 2023

smohamedjavid left a comment

smohamedjavid Jun 9, 2023

smohamedjavid Jun 9, 2023

jo-mut commented Jun 14, 2023

status-im-auto commented Jun 14, 2023

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityMultipleDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMerged:

Class TestActivityMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityOneDeviceMerged:

jo-mut commented Jun 14, 2023 •

edited

Loading

jo-mut commented Jun 14, 2023

status-im-auto commented Jun 14, 2023

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestCommunityMultipleDeviceMerged:

VolodLytvynenko commented Jun 14, 2023

jo-mut commented Jun 15, 2023

VolodLytvynenko commented Jun 15, 2023

jo-mut commented Jun 15, 2023

VolodLytvynenko commented Jun 15, 2023

onboarding syncing updates #16206

onboarding syncing updates #16206

Conversation

jo-mut commented Jun 6, 2023 • edited Loading

Summary

status-im-auto commented Jun 6, 2023 • edited Loading

Jenkins Builds

ulisesmac commented Jun 9, 2023

jo-mut commented Jun 9, 2023 • edited Loading

ulisesmac commented Jun 9, 2023

ulisesmac left a comment

Choose a reason for hiding this comment

ulisesmac Jun 9, 2023

Choose a reason for hiding this comment

smohamedjavid Jun 9, 2023

Choose a reason for hiding this comment

ulisesmac Jun 9, 2023

Choose a reason for hiding this comment

ulisesmac Jun 9, 2023

Choose a reason for hiding this comment

smohamedjavid left a comment

Choose a reason for hiding this comment

smohamedjavid Jun 9, 2023

Choose a reason for hiding this comment

smohamedjavid Jun 9, 2023

Choose a reason for hiding this comment

jo-mut commented Jun 14, 2023

status-im-auto commented Jun 14, 2023

76% of end-end tests have passed

Failed tests (8)

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityMultipleDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Passed tests (25)

Class TestCommunityMultipleDeviceMerged:

Class TestActivityMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityOneDeviceMerged:

jo-mut commented Jun 14, 2023 • edited Loading

jo-mut commented Jun 14, 2023

status-im-auto commented Jun 14, 2023

100% of end-end tests have passed

Passed tests (3)

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestCommunityMultipleDeviceMerged:

VolodLytvynenko commented Jun 14, 2023

jo-mut commented Jun 15, 2023

VolodLytvynenko commented Jun 15, 2023

jo-mut commented Jun 15, 2023

VolodLytvynenko commented Jun 15, 2023

jo-mut commented Jun 6, 2023 •

edited

Loading

status-im-auto commented Jun 6, 2023 •

edited

Loading

jo-mut commented Jun 9, 2023 •

edited

Loading

jo-mut commented Jun 14, 2023 •

edited

Loading