Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Home-stack overlaps bottom tabs in Xiaomi devices on first run #15821

Merged
merged 1 commit into from
May 9, 2023
Merged

fix Home-stack overlaps bottom tabs in Xiaomi devices on first run #15821

merged 1 commit into from
May 9, 2023

Conversation

Parveshdhull
Copy link
Member

@Parveshdhull Parveshdhull commented May 5, 2023 •
edited
Loading

fixes: #15164

Review Notes:

Leftover from #14639 (comment)
Moving screen height to on-boarding, so home-stack height will be correct even for first run.

Testing

@churik @pavloburykh can you please check if this fixes the home-stack height in xiaomi device and emulator

status: ready

@Parveshdhull Parveshdhull self-assigned this May 5, 2023
@status-im-auto
Copy link
Member

status-im-auto commented May 5, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (8)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 9960cfc #1 2023-05-05 11:12:31 ~5 min android 🤖apk 📲
✔️ 9960cfc #1 2023-05-05 11:12:56 ~6 min android-e2e 🤖apk 📲
✔️ 9960cfc #1 2023-05-05 11:12:58 ~5 min tests 📄log
✔️ 9960cfc #1 2023-05-05 11:13:52 ~6 min ios 📱ipa 📲
✔️ 000fda7 #2 2023-05-05 11:24:23 ~6 min android 🤖apk 📲
✔️ 000fda7 #2 2023-05-05 11:24:26 ~6 min ios 📱ipa 📲
✔️ 000fda7 #2 2023-05-05 11:25:33 ~7 min android-e2e 🤖apk 📲
✔️ 000fda7 #2 2023-05-05 11:25:47 ~7 min tests 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 10e8ed4 #3 2023-05-08 13:30:56 ~5 min tests 📄log
✔️ 10e8ed4 #3 2023-05-08 13:31:46 ~6 min android-e2e 🤖apk 📲
✔️ 10e8ed4 #3 2023-05-08 13:31:54 ~6 min ios 📱ipa 📲
✔️ 10e8ed4 #3 2023-05-08 13:32:04 ~6 min android 🤖apk 📲
✔️ 0378b0a #4 2023-05-09 10:27:33 ~6 min ios 📱ipa 📲
✔️ 0378b0a #4 2023-05-09 10:27:59 ~7 min android-e2e 🤖apk 📲
✔️ 0378b0a #4 2023-05-09 10:28:20 ~7 min android 🤖apk 📲
✔️ 0378b0a #4 2023-05-09 10:30:21 ~9 min tests 📄log

@Parveshdhull Parveshdhull changed the title test: fix Home-stack overlaps bottom tabs in Xiaomi devices on first run fix Home-stack overlaps bottom tabs in Xiaomi devices on first run May 8, 2023
@Parveshdhull Parveshdhull force-pushed the fix/android-window-height branch from 000fda7 to 10e8ed4 Compare May 8, 2023 13:24
@Parveshdhull Parveshdhull marked this pull request as ready for review May 8, 2023 13:25
@status-im-auto
Copy link
Member

90% of end-end tests have passed

Total executed tests: 20
Failed tests: 2
Passed tests: 18
Not executed tests: 11

IDs of not executed tests: 702807,702732,702808,702846,702742,703133,702850,702851,702936,702947,702957 

IDs of failed tests: 702958,702838

Not executed tests (11)

Click to expand
  • Rerun not executed tests

    • Failed tests (2)

    Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Verifying that 'hello' is under today
    Device 2: Looking for a message by text: hello 

    critical/test_public_chat_browsing.py:461: in test_community_message_send_check_timestamps_sender_username
    channel.verify_message_is_under_today_text(message, self.errors)
../views/chat_view.py:927: in verify_message_is_under_today_text
    message_element.wait_for_visibility_of_element()
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element

    [[blocked by 14797]]

    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_admin_notification_accept_swipe, id: 702958 

    Test setup failed: medium/test_activity_center.py:115: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
 cannot unpack non-iterable NoneType object



    Passed tests (18)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    2. test_1_1_chat_edit_message, id: 702855
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    5. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    6. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    9. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    2. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    5. test_community_leave, id: 702845
    Device sessions

    6. test_community_unread_messages_badge, id: 702841
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    9. test_community_message_edit, id: 702843
    Device sessions

    @status-im-auto
    Copy link
    Member

    84% of end-end tests have passed

    Total executed tests: 31
Failed tests: 5
Passed tests: 26

    IDs of failed tests: 702840,702732,702807,702808,702838

    Failed tests (5)

    Click to expand
  • Rerun failed tests

    • Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 
    Test setup failed: critical/chats/test_group_chat.py:198: in prepare_devices
    self.chats[0] = self.homes[0].create_group_chat(user_names_to_add=[self.usernames[1], self.usernames[2]]</b>,
../views/home_view.py:359: in create_group_chat
    chat.chat_name_editbox.send_keys(group_chat_name)
../views/base_element.py:348: in send_keys
    self.find_element().send_keys(value)
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 1: EditBox by accessibility id: `chat-name-input` is not found on the screen



    2. test_group_chat_join_send_text_messages_push, id: 702807

    Device 1: Tap on found: Button
    Device 1: Find EditBox by accessibility id: chat-name-input 

    Test setup failed: critical/chats/test_group_chat.py:198: in prepare_devices
    self.chats[0] = self.homes[0].create_group_chat(user_names_to_add=[self.usernames[1], self.usernames[2]]</b>,
../views/home_view.py:359: in create_group_chat
    chat.chat_name_editbox.send_keys(group_chat_name)
../views/base_element.py:348: in send_keys
    self.find_element().send_keys(value)
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 1: EditBox by accessibility id: `chat-name-input` is not found on the screen



    Device sessions

    3. test_group_chat_offline_pn, id: 702808 

    Test setup failed: critical/chats/test_group_chat.py:198: in prepare_devices
    self.chats[0] = self.homes[0].create_group_chat(user_names_to_add=[self.usernames[1], self.usernames[2]]</b>,
../views/home_view.py:359: in create_group_chat
    chat.chat_name_editbox.send_keys(group_chat_name)
../views/base_element.py:348: in send_keys
    self.find_element().send_keys(value)
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 1: EditBox by accessibility id: `chat-name-input` is not found on the screen



    Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840

    Device 1: Find RepliedMessageText by xpath: //*[starts-with(@text,'test message')]/preceding::android.widget.TextView[@content-desc='quoted-message']
    Device 1: RepliedMessageText is 📶 

    critical/test_public_chat_browsing.py:526: in test_community_emoji_send_copy_paste_reply
    self.errors.verify_no_errors()
base_test_case.py:184: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Emoji message was not copied

    [[flaky test; sometimes can not be copied through appium]]

    Device sessions

    2. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Verifying that 'hello' is under today
    Device 2: Looking for a message by text: hello 

    critical/test_public_chat_browsing.py:461: in test_community_message_send_check_timestamps_sender_username
    channel.verify_message_is_under_today_text(message, self.errors)
../views/chat_view.py:927: in verify_message_is_under_today_text
    message_element.wait_for_visibility_of_element()
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element

    [[blocked by 14797]]

    Device sessions

    Passed tests (26)

    Click to expand

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    3. test_navigation_jump_to, id: 702936
    Device sessions

    4. test_activity_center_mentions, id: 702957
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    2. test_1_1_chat_edit_message, id: 702855
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    5. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    6. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    9. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    2. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    3. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    2. test_community_mentions_push_notification, id: 702786
    Device sessions

    3. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    5. test_community_unread_messages_badge, id: 702841
    Device sessions

    6. test_community_message_delete, id: 702839
    Device sessions

    7. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    8. test_community_message_edit, id: 702843
    Device sessions

    @pavloburykh
    Copy link
    Contributor

    @Parveshdhull thanx for the fix! Looks good both for me on emulator and for @churik on her Xiaomi. Failed tests are not PR related. Ready to be merged.

    @pavloburykh pavloburykh self-assigned this May 9, 2023
    @Parveshdhull Parveshdhull force-pushed the fix/android-window-height branch from 10e8ed4 to 0378b0a Compare May 9, 2023 10:20
    @Parveshdhull Parveshdhull merged commit ebb110e into develop May 9, 2023
    @Parveshdhull Parveshdhull deleted the fix/android-window-height branch May 9, 2023 10:33
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @smohamedjavid smohamedjavid smohamedjavid approved these changes

    @flexsurfer flexsurfer Awaiting requested review from flexsurfer

    @ibrkhalil ibrkhalil Awaiting requested review from ibrkhalil

    Assignees

    @Parveshdhull Parveshdhull

    @pavloburykh pavloburykh

    Labels
    request-manual-qa Tested - OK
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Home-stack overlaps bottom tabs in Xiaomi devices on first run
    4 participants
    @Parveshdhull @status-im-auto @pavloburykh @smohamedjavid