[WIP] upgrade reanimated to v3 #15769
Conversation
There was a problem hiding this comment.
hmm something went wrong over here, we should revert this file to the way it was
Jenkins BuildsClick to see older builds (41)
|
|
When running
Upgrading NDK to version
Also, running
|
|
Hi @jakubgs, |
|
It doesn't seem like you changed the SDK version: If it even is available in our version of nixpkgs. |
|
@jakubgs I tried changing it, and then reverted it back |
|
I have just pushed a commit with the updated version to see if it will be any different on CI. (and it seems there is no difference) Btw, I see the NDK version in |
|
The AAPT2 build issue is known, and was fixed in one of the RN update PRs with this: d69277ed |
|
Yes, value in Also, please don't add a root slash to relative paths. |
@jakubgs after doing that update to |
|
No, that's not the error. That's just what is printed after the actual error. Are you sure you updated them? |
|
Oh, I see, running That's what the I've pushed a commit with updated dependencies. |
|
But I see this is more complex than just that. It needs more work. |
|
@jakubgs Trying to run |
So what does it need :) |
Signed-off-by: Jakub Sokołowski <[email protected]>
|
It means it needs more work. Also, please use triple backticks for large logs, otherwise the formatting is disgusting: |
Signed-off-by: Jakub Sokołowski <[email protected]>
Signed-off-by: Jakub Sokołowski <[email protected]>
|
Pushed some of my changes, but the fundamental issue is in the sub-projects that specify |
|
@siddarthkay already created a tagged release of Which does make it possible to override the Kotlin Gradle Plugin version, as seen here: def kotlin_version = rootProject.ext.has('RNHV_kotlinVersion') ? rootProject.ext.get('RNHV_kotlinVersion') : project.properties['RNHV_kotlinVersion']
def gradle_version = rootProject.ext.has('RNHV_gradleVersion') ? rootProject.ext.get('RNHV_gradleVersion') : project.properties['RNHV_gradleVersion']https://github.com/status-im/react-native-hole-view/blob/v2.1.3-status/android/build.gradle#L3-L4 |
|
Using Or specifically, a missing JAR/AAR for the POM: That's an edge case that we should already be handing but we do not: status-mobile/nix/deps/gradle/url2json.sh Lines 113 to 114 in 6aae68b |
Signed-off-by: Jakub Sokołowski <[email protected]>
Signed-off-by: Jakub Sokołowski <[email protected]>
``` * What went wrong: Could not determine the dependencies of task ':app:lintVitalReportPr'. > Failed to find Build Tools revision 30.0.3 ``` Signed-off-by: Jakub Sokołowski <[email protected]>
|
This is an issue that we already saw in the RN upgrade PR(#15203 (comment)): For now I can add it manually, but it will disappear at next use of |
Signed-off-by: Jakub Sokołowski <[email protected]>
|
Wht the fuck is this: |
@siddarthkay we can get rid of v1 code immediately no problem. I don't think we are using v1 code in |
@jakubgs possibly related issue: software-mansion/react-native-reanimated#3638 |
|
Well, that issue says to upgrade to v2, which is probably not what we want: This can be found in the strace log from Gradle. It's looking for it in: Wtf is this and why it's trying to download it in some custom way? No idea. |
|
Apparently this is only necessary when using RN older than 71: if (REACT_NATIVE_MINOR_VERSION < 71) {
// You need to have following folders in this directory:
// - boost_1_63_0
// - double-conversion-1.1.6
// - folly-deprecate-dynamic-initializer
// - glog-0.3.5
def dependenciesPath = System.getenv("REACT_NATIVE_DEPENDENCIES")
// The Boost library is a very large download (>100MB).
// If Boost is already present on your system, define the REACT_NATIVE_BOOST_PATH env variable
// and the build will use that.
def boostPath = dependenciesPath ?: System.getenv("REACT_NATIVE_BOOST_PATH")Now that's some dumb shit. Do they just expect people to download those manually? |
|
They actually download them: if (REACT_NATIVE_MINOR_VERSION < 71) {
extractAARHeaders.dependsOn(prepareThirdPartyNdkHeaders)
extractSOFiles.dependsOn(prepareThirdPartyNdkHeaders)
nativeBuildDependsOn(prepareThirdPartyNdkHeaders) task prepareThirdPartyNdkHeaders(dependsOn:[
downloadNdkBuildDependencies, task downloadBoost(dependsOn: resolveBoost, type: Download) {
def transformedVersion = BOOST_VERSION.replace("_", ".")
def artifactLocalName = "boost_${BOOST_VERSION}.tar.gz"
def srcUrl = "https://boostorg.jfrog.io/artifactory/main/release/${transformedVersion}/source/boost_${BOOST_VERSION}.tar.gz"
if (REACT_NATIVE_MINOR_VERSION < 69) {
srcUrl = "https://github.com/react-native-community/boost-for-react-native/releases/download/v${transformedVersion}-0/boost_${BOOST_VERSION}.tar.gz"
}But since the Nix build is pure there is no network for it to do that. Why do they re-invent the wheel and do their own dependency management? Who thought this was a good idea? Or we could actually do the React Native upgrade... |
|
@jakubgs : I am resuming work on the upgrade this week, should be fun, will keep you posted. |
Oh I see.. |
|
Fine we can do the RN upgrade then |
|
Dependency: #15203 |
|
feel free to reopen when needed, or create a new one |
fixes: #15764