-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow styling text in composer when selecting it with native actions #14249
Conversation
Jenkins BuildsClick to see older builds (48)
|
3dfc0b4
to
3f45341
Compare
Hey @qfrank, can you please explain why the implementation is done natively? As far as I understand from the designs it does not need to be styled in the composer itself. |
As someone else may have same question, i'd like to put this quote here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to add unit testing to this functionality ?
...status/android/src/main/java/im/status/ethereum/module/RNSelectableTextInputViewManager.java
Show resolved
Hide resolved
...status/android/src/main/java/im/status/ethereum/module/RNSelectableTextInputViewManager.java
Outdated
Show resolved
Hide resolved
...status/android/src/main/java/im/status/ethereum/module/RNSelectableTextInputViewManager.java
Outdated
Show resolved
Hide resolved
...status/android/src/main/java/im/status/ethereum/module/RNSelectableTextInputViewManager.java
Outdated
Show resolved
Hide resolved
@qfrank, I tried to run the app locally, but unfortunately https://github.com/qfrank/status-react/tree/feature/14137 fails to me with the error below. Even the develop branch in your fork fails to me. To double-check it wasn't a problem on my machine, I rebased
|
Hi @ilmotta , rebased, enjoy! |
Hi @ibrkhalil , thanks for your review, a lot of align task :), can we leave the align task later to |
i don't think we need here, if u know there is a way, i'd like to hear |
Thanks @qfrank. I could successfully run it now. So I tried in the Android Emulator, and I took two screenshots (below) where we can see the native BIU menu option. The functionality works, but the behavior and implementation is completely different from what I see in Figma (https://www.figma.com/file/wA8Epdki2OWa8Vr067PCNQ/Composer-for-Mobile?node-id=2230%3A116813). A couple important differences:
Where's the Figma spec showing we should implement a native BIU option in the popup menu? The image below shows the styling button is not in a popup menu. Hence I actually don't understand how this PR is implementing what the Figma specs require. Could you help me understand why the mismatch between this PR's implementation and the Figma specs? |
I don't know if it helps you, but this Cursive page says aligning let bindings is supported. And you're right, |
Good questions, i had a conversation with petro.et before (i should ask it in public channel ):), let me quote here:
I guess above would answer the first difference? |
U saved my life! thanks a lot @ilmotta |
Thanks for the clarifications @qfrank, it seems we're good for now :) Changing subject: Figma shows a menu option with styling, can we do that in the native menu option for Android? It would be great if we could do that, because the acronym |
i believe we can style the popup menu, but it's another issue we need process :) |
Sounds great to me @qfrank. On top of that, in the PR description you mentioned about getting help from someone with iOS experience. I guess that could be another issue as well, right? |
785ec6d
to
08f09b6
Compare
83% of end-end tests have passed
Not executed tests (1)Failed tests (1)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Passed tests (5)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestDeeplinkOneDevice:
|
@qfrank thank you for the update! On Xiaomi Mi 9T Pro (Android 10) - there is no option for me at all: On Samsung Galaxy A52 (Android 11) it can be opened, but not on the first attempt: FILE.2022-11-18.14.58.53.mp4On Huawei P40 Lite, EMUI 12 (android 11): works as expected. I can try some virtual devices if needed, let me know. |
UPD: works fine on Samsung Galaxy with Android10, but not on Xiaomi phones regardless of Android version. |
i may need prepare a xiaomi device then :( , i will try it next week, thank you @churik |
we have browserstack! I can share details |
@churik Do you see a custom menu on whatsapp on Xiaomi phones? If no, I'd say this would be a won't fix, otherwise we might look into it. |
08f09b6
to
06f006c
Compare
Hi @churik , this one just get fixed :)
|
Hi @qfrank. Thank you for the PR. Please, take a look at the following issues ISSUE 1. The text is not shown as styled if a user is typing it within styling frames Steps to reproduce:
Actual result: Expected result: ISSUE 2. Text is not shown in style if the current text is wrapped into all together styles Steps to reproduce:
Actual result: Expected result How it is implemented within WhatsApp ISSUE 3. The pop up is not shown with BIU option for the some devices
Actual result: Expected result: |
I guess all the issues can be addressed separetely, not crucial from my POV. |
@qfrank thank you for your work. |
06f006c
to
5850510
Compare
notice again, we need the IOS implementation :) |
close(partially) #14137
note: this PR doesn't contain corresponding implementation for Ios yet, someone's help would appreciated :)