Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix status-bar on Android #12781

Merged
merged 0 commits into from
Nov 2, 2021
Merged

fix status-bar on Android #12781

merged 0 commits into from
Nov 2, 2021

Conversation

flexsurfer
Copy link
Member

Revert of this change #12544,
we need to find out why this change was made, because I tested on two Android phones and statusbar works fine in both light and dark modes, probably PR was fixing just some specific case @Parveshdhull ?

@flexsurfer flexsurfer self-assigned this Nov 2, 2021
@status-im-auto
Copy link
Member

status-im-auto commented Nov 2, 2021 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 990044f #1 2021-11-02 08:57:47 ~11 min android-e2e 📦apk 📲
✔️ 990044f #1 2021-11-02 09:02:04 ~16 min android 📦apk 📲
✔️ 990044f #1 2021-11-02 09:02:23 ~16 min ios 📦ipa 📲

@status-im-auto
Copy link
Member

96% of end-end tests have passed

Total executed tests: 69
Failed tests: 3
Passed tests: 66

IDs of failed tests: 6316,6645,5304

Failed tests (3)

Click to expand
  • Rerun tests

    • 1. test_send_audio_message_with_push_notification_check, id: 6316

    Device 2: Find 'Text' by 'xpath': `//*[@content-desc='play-pause-audio-message-button']/../..//android.widget.TextView[1]`
    Device 2: 'Text' is '00:05'

    Timer exceed 2 minutes

    Device sessions

    2. test_restore_account_migrate_multiaccount_to_keycard, id: 6645

    Device 1: Tap on found: Button
    Device 1: Find 'EditBox' by 'xpath': `(//android.widget.EditText[@content-desc='password-input'])[1]`

    Device 1: EditBox by xpath: `(//android.widget.EditText[@content-desc='password-input'])[1]` is not found on the screen; also Unexpected Alert is shown: 'java.lang.NullPointerException: Attempt to invoke virtual method 'android.graphics.drawable.Drawable

    Device sessions

    3. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304

    Device 1: Find 'BackButton' by 'accessibility id': `Navigate Up`
    Device 1: Looking for chat: 'Royal Defensive Solenodon'

    ENS name is not resolved after pasting chat key

    Device sessions

    Passed tests (66)

    Click to expand

    1. test_image_in_one_to_one_send_save_reply_timeline, id: 6305
    Device sessions

    2. test_add_account_to_multiaccount_instance_generate_new, id: 6224
    Device sessions

    3. test_can_add_existing_ens_on_mainnet, id: 5502
    Device sessions

    4. test_keycard_can_see_all_transactions_in_history, id: 6291
    Device sessions

    5. test_sign_message_and_2tx_in_batch_and_transactions_filters_from_daap, id: 5342
    Device sessions

    6. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244
    Device sessions

    7. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210
    Device sessions

    8. test_open_public_chat_using_deep_link, id: 5396
    Device sessions

    9. test_offline_add_new_group_chat_member, id: 3998
    Device sessions

    10. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
    Device sessions

    11. test_can_see_balance_and_all_transactions_history_on_cellular, id: 5314
    Device sessions

    12. test_insufficient_funds_wallet_positive_balance, id: 5412
    Device sessions

    13. test_delete_close_all_tabs, id: 5390
    Device sessions

    14. test_create_new_group_chat_messaging_pn_delivered, id: 3994
    Device sessions

    15. test_send_token_with_7_decimals, id: 5350
    Device sessions

    16. test_delete_chats_via_delete_button_rejoin, id: 5387
    Device sessions

    17. test_send_transaction_set_recipient_options, id: 6328
    Device sessions

    18. test_keycard_sign_message_and_transactions_from_daap, id: 6251
    Device sessions

    19. test_recover_account_from_new_user_seedphrase, id: 6296
    Device sessions

    20. test_keycard_can_recover_keycard_account_card_pairing, id: 5758
    Device sessions

    21. test_block_user_from_public_chat, id: 5786
    Device sessions

    22. test_redirect_to_public_chat_tapping_tag_message_fetch_more_history, id: 5675
    Device sessions

    23. test_edit_delete_message_in_one_to_one_and_public_chats, id: 695843
    Device sessions

    24. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
    Device sessions

    25. test_keycard_send_eth_from_wallet_to_address, id: 6289
    Device sessions

    26. test_keycard_create_login_restore_unlock_same_seed, id: 5689
    Device sessions

    27. test_add_account_to_wallet_private_key_and_seed_phrase, id: 6272
    Device sessions

    28. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
    Device sessions

    29. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
    Device sessions

    30. test_long_press_to_delete_chat, id: 5319
    Device sessions

    31. test_copy_and_paste_messages, id: 5317
    Device sessions

    32. test_open_transaction_on_etherscan_copy_tx_hash, id: 5384
    Device sessions

    33. test_unread_messages_counter_public_chat, id: 5360
    Device sessions

    34. test_send_eth_from_wallet_to_address_incorrect_password, id: 5308
    Device sessions

    35. test_mobile_data_usage_complex_settings, id: 6228
    Device sessions

    36. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
    Device sessions

    37. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265
    Device sessions

    38. test_send_eth_in_1_1_chat_transaction_push, id: 6253
    Device sessions

    39. test_install_pack_and_send_sticker, id: 5782
    Device sessions

    40. test_switch_users_special_char_password_and_add_new_account_logcat, id: 5356
    Device sessions

    41. test_manage_assets, id: 5341
    Device sessions

    42. test_browser_managing_bookmarks, id: 6633
    Device sessions

    43. test_request_stt_from_daap, id: 5309
    Device sessions

    44. test_can_use_purchased_stickers_on_recovered_account, id: 5783
    Device sessions

    45. test_dapps_permissions, id: 5738
    Device sessions

    46. test_account_recovery_with_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 5394
    Device sessions

    47. test_send_eth_to_ens_in_chat, id: 6279
    Device sessions

    48. test_share_copy_contact_code_and_wallet_address, id: 5323
    Device sessions

    49. test_wallet_set_up, id: 5335
    Device sessions

    50. test_send_transaction_with_custom_token, id: 6208
    Device sessions

    51. test_home_view, id: 5379
    Device sessions

    52. test_logcat_backup_recovery_phrase, id: 5419
    Device sessions

    53. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263
    Device sessions

    54. test_set_profile_picture, id: 6646
    Device sessions

    55. test_collectible_from_wallet, id: 5346
    Device sessions

    56. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
    Device sessions

    57. test_keycard_request_stt_from_daap, id: 6249
    Device sessions

    58. test_restore_account_from_mnemonic_to_keycard, id: 6240
    Device sessions

    59. test_pass_phrase_validation, id: 5363
    Device sessions

    60. test_user_can_see_collectibles_on_rinkeby_after_account_recovering, id: 5381
    Device sessions

    61. test_keycard_send_eth_in_1_1_chat, id: 6293
    Device sessions

    62. test_send_and_open_links_with_previews, id: 5373
    Device sessions

    63. test_reactions_to_message_in_chats, id: 6315
    Device sessions

    64. test_fetching_balance_after_offline, id: 6237
    Device sessions

    65. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
    Device sessions

    66. test_public_chat_messaging_emojis_timestamps, id: 5313
    Device sessions

    Parveshdhull
    Parveshdhull reviewed Nov 2, 2021
    View reviewed changes
    Copy link
    Member

    @Parveshdhull Parveshdhull left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Hi @flexsurfer, some of my notification icons are not blending in background.

    May be this distortion behaviour is device specific due to icon colours in my device or something.

    Please feel free to revert changes 👍
    Thanks

    Screenshot_2021-11-02-16-00-46-94.png

    @flexsurfer flexsurfer merged commit 8dc6d8d into develop Nov 2, 2021
    @flexsurfer flexsurfer force-pushed the bug/status-bar-android branch from 990044f to 8dc6d8d Compare November 2, 2021 11:19
    @flexsurfer flexsurfer deleted the bug/status-bar-android branch November 2, 2021 11:19
    @du82
    Copy link
    Contributor

    du82 commented Nov 3, 2021

    This is broken again, please revert back to that PR being enabled because it worked much better.

    Screenshot_20211102-190031_Status PR

    @du82
    Copy link
    Contributor

    du82 commented Nov 3, 2021

    The PR you reversed was really helpful, now the menus are back to being glitchy.

    @flexsurfer
    Copy link
    Member Author

    then @ducheng0 , @Parveshdhull could you tell model of your devices and OS version, thanks

    @flexsurfer
    Copy link
    Member Author

    @churik could QA check on different Android devices ? on all my devices this PR works perfect

    @Parveshdhull
    Copy link
    Member

    then @ducheng0 , @Parveshdhull could you tell model of your devices and OS version, thanks

    Mine is Real me 1 and android version 9.
    thanks

    @flexsurfer
    Copy link
    Member Author

    anyway if there is a bug on some ANdroid devices, we need to create a new issue and fix it properly

    @Parveshdhull
    Copy link
    Member

    Sounds, great 👍
    Thanks

    @flexsurfer
    Copy link
    Member Author

    I've filed a bug in RNN wix/react-native-navigation#7339

    @churik
    Copy link
    Member

    churik commented Nov 3, 2021

    @flexsurfer tested on most used devices / OS:

    • on Android 9 (Galaxy A10):
      nightly1 png 2021-11-03 12-11-05

    • on Android10 (Samsung Galaxy S20+):
      samsung10

    • on Android10(Xiaomi Redmi Note9):
      chin_night_10 png 2021-11-03 12-14-57

    • on Android11 (Google Pixel 5):
      nightly_11 png 2021-11-03 12-16-48

    So basically for some devices it is black, for some it is grey.
    Feel free to merge if PR version looks more fancy from your POV

    @du82
    Copy link
    Contributor

    du82 commented Nov 3, 2021

    then @ducheng0 , @Parveshdhull could you tell model of your devices and OS version, thanks

    @Parveshdhull
    Samsung A50, Android 11
    Samsung Galaxy Tab A, Android 9
    Google Pixel 4 Emulator

    Looks like a bug, because on my development tablet, it shows a status-colored blue bar at the top, on my phone it shows a black bar, and on the Google Pixel emulator it looks grey like it should.

    @flexsurfer
    Copy link
    Member Author

    new issue #12806

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @Parveshdhull Parveshdhull Parveshdhull approved these changes

    @rasom rasom rasom approved these changes

    Assignees

    @flexsurfer flexsurfer

    Labels
    None yet
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    6 participants
    @flexsurfer @status-im-auto @du82 @Parveshdhull @churik @rasom