Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The name of saved address Is not shown if sending is processed from the wallet settings #20593

Closed
VolodLytvynenko opened this issue Jun 27, 2024 · 0 comments · Fixed by #21448
Closed

The name of saved address Is not shown if sending is processed from the wallet settings #20593

VolodLytvynenko opened this issue Jun 27, 2024 · 0 comments · Fixed by #21448
Assignees
@mohsen-ghafouri
Labels
wallet: Settings All issues for the mobile wallet settings wallet-core Issues for mobile wallet team
Milestone
2.32.0

Comments

@VolodLytvynenko
Copy link
Contributor

follow up for #20480

Steps:

  1. Go to wallet settings -> select 'Saved Addresses' -> select any saved address.
  2. Tap 'Send to ' option.
  3. Go to the send flow.
  4. Check the confirmation page.

Actual result:

The name of the saved address is not shown on the confirmation page.

saved2.mp4

Expected result:

The name of the saved address is shown on the confirmation page.
image
@VolodLytvynenko VolodLytvynenko added 🔢 low prio bug wallet: Settings All issues for the mobile wallet settings labels Jun 27, 2024
@mmilad75 mmilad75 self-assigned this Jun 27, 2024
@VolodLytvynenko VolodLytvynenko added the wallet-core Issues for mobile wallet team label Jul 4, 2024
@mmilad75 mmilad75 removed their assignment Jul 26, 2024
@shivekkhurana shivekkhurana added this to the 2.31.0 Beta milestone Oct 3, 2024
@mohsen-ghafouri mohsen-ghafouri self-assigned this Oct 4, 2024
@ilmotta ilmotta removed the bug label Oct 14, 2024
mohsen-ghafouri added a commit that referenced this issue Oct 16, 2024
@mohsen-ghafouri
[#20593] fix: show name of saved address in sending flow
d5a8ea9
@mohsen-ghafouri mohsen-ghafouri mentioned this issue Oct 16, 2024
Merged
@mohsen-ghafouri mohsen-ghafouri moved this from In Progress to Code Review in Status Desktop/Mobile Board Oct 16, 2024
mohsen-ghafouri added a commit that referenced this issue Oct 17, 2024
@mohsen-ghafouri
[#20593] fix: show name of saved address in sending flow
94fba2d
mohsen-ghafouri added a commit that referenced this issue Oct 17, 2024
@mohsen-ghafouri
[#20593] fix: show name of saved address in sending flow (#21448)
6105435
@github-project-automation github-project-automation bot moved this from Code Review to Done in Status Desktop/Mobile Board Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mohsen-ghafouri mohsen-ghafouri

Labels
wallet: Settings All issues for the mobile wallet settings wallet-core Issues for mobile wallet team
Projects
Status Desktop/Mobile Board
Archived in project
Milestone
2.32.0
Development

Successfully merging a pull request may close this issue.

[#20593] fix: show name of saved address in sending flow status-im/status-mobile
5 participants
@ilmotta @shivekkhurana @VolodLytvynenko @mmilad75 @mohsen-ghafouri