Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline fetching and resending messages is not working from mobile devices on shards.test #18272

Closed
churik opened this issue Dec 21, 2023 · 6 comments

Comments

@churik
Copy link
Member

churik commented Dec 21, 2023

Bug Report

Problem

The bug is not reproducible on the current develop branch and was not reproducible during testing #18115

Expected behavior

  • can fetch messages from offline (4,5,6) + new channel
  • can resend messages while sending from offline after getting back online (1,2,3)

Actual behavior

  • no messages and community updates are received while getting back from offline
  • messages are stuck in "Sending" forever

Reproduction

As a desktop: create community

  1. Mobile: join community
  2. Mobile: go offline
  3. Mobile: post messages 1,2,3
  4. Desktop: post messages 4,5,6 + add channel2
  5. Mobile: go online

Additional Information

  • Status version: RC 17
  • Operating System: Android, iOS
FILE.2023-12-21.17.27.10.mp4

Logs

Desktop (build): geth.log
Mobile (build): logs (78).zip

@churik
Copy link
Member Author

churik commented Dec 21, 2023

@VolodLytvynenko
Copy link
Contributor

VolodLytvynenko commented Dec 21, 2023

I confirm everything that @churik described here
Tested in case Mobile -> Mobile

Reproduction
As a desktop: create community share to Mobile 1: and Mobile 2:

Mobile 1: join the community and send message 1
Mobile 2:join community (Now message 1 is not visible)
Mobile 2: go offline
Mobile 1: send 3-5 messages
Mobile 2: go online

Actual result:

no messages and community updates are received while getting back from offline

My.Movie.5.mp4

Logs:

@richard-ramos
Copy link
Member

I see a lot of cannot do on demand discovery for non-waku protocol errors that were fixed in go-waku in waku-org/go-waku#951. I'll update the status-go branch with that go-waku version and this mobile PR

@richard-ramos
Copy link
Member

Hm, the test-shard-test branch of status-go does contain the changes, yet the feature/peersyncing does not. I ended up updating go-waku on that branch. So we'd need to update the mobile branch to use this status-im/status-go@c3739ed

But IMO the way to go should be to create a branch in status-go that uses test-shard-test as base, and include the commits from feature/peersyncing.

@richard-ramos
Copy link
Member

I'm also not sure which branch is being used in status-mobile so I can update its status-go version

@churik
Copy link
Member Author

churik commented Dec 22, 2023

Bug was introduced due to invalid rebase, fixed in build 18

@churik churik closed this as completed Dec 22, 2023
@ilmotta ilmotta removed the bug label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants