Merge branch 'develop' into 16247

.detoxrc.js

@@ -1,37 +1,37 @@
 module.exports = {
-  "testRunner": "jest",
-  "testRegex": "\\.visual\\.js$",
-  "runner-config": "visual-test/config.json",
-  "devices": {
-    "simulator": {
-      "type": "ios.simulator",
-      "device": {
-        "type": "iPhone 11 Pro"
-      }
-    }
+  testRunner: 'jest',
+  testRegex: '\\.visual\\.js$',
+  'runner-config': 'visual-test/config.json',
+  devices: {
+    simulator: {
+      type: 'ios.simulator',
+      device: {
+        type: 'iPhone 11 Pro',
+      },
+    },
   },
-  "apps": {
-    "ios.release": {
-      "name": "StatusIm",
-      "type": "ios.app",
-      "binaryPath": "ios/build/Build/Products/Release-iphonesimulator/StatusIm.app",
-      "build": "make release-ios"
+  apps: {
+    'ios.release': {
+      name: 'StatusIm',
+      type: 'ios.app',
+      binaryPath: 'ios/build/Build/Products/Release-iphonesimulator/StatusIm.app',
+      build: 'make release-ios',
+    },
+    'ios.debug': {
+      name: 'StatusIm',
+      type: 'ios.app',
+      binaryPath: process.env.TEST_BINARY_PATH,
+      build: "make run-ios SIMULATOR='iPhone 11 Pro'",
     },
-    "ios.debug": {
-      "name": "StatusIm",
-      "type": "ios.app",
-      "binaryPath": process.env.TEST_BINARY_PATH,
-      "build": "make run-ios SIMULATOR='iPhone 11 Pro'"
-    }
   },
-  "configurations": {
-    "ios.sim.release": {
-      "device": "simulator",
-      "app": "ios.release"
+  configurations: {
+    'ios.sim.release': {
+      device: 'simulator',
+      app: 'ios.release',
     },
-    "ios.sim.debug": {
-      "device": "simulator",
-      "app": "ios.debug"
-    }
-  }
-}
+    'ios.sim.debug': {
+      device: 'simulator',
+      app: 'ios.debug',
+    },
+  },
+};

.eslintrc.js

@@ -1,4 +1,4 @@
 module.exports = {
-    root: true,
-    extends: '@react-native-community',
-  };
+  root: true,
+  extends: '@react-native-community',
+};

.prettierignore

@@ -0,0 +1,7 @@
+*
+!*.js
+!*/
+*.clj-kondo
+*.shadow-cljs
+modules
+result

.prettierrc.js

@@ -1,7 +1,9 @@
 module.exports = {
-    bracketSpacing: false,
-    bracketSameLine: true,
-    singleQuote: true,
-    trailingComma: 'all',
-    tabWidth: 4,
+  arrowParens: 'always',
+  printWidth: 120,
+  semi: true,
+  singleQuote: true,
+  tabWidth: 2,
+  trailingComma: 'all',
+  useTabs: false,
 };

Makefile

@@ -81,6 +81,10 @@ nix-gc-protected:
 	@echo -e "$(YELLOW)The following paths are protected:$(RESET)" && \
 	ls -1 $(_NIX_GCROOTS) | sed 's/^/ - /'
 
+nix-upgrade: SHELL := /bin/sh
+nix-upgrade: ##@nix Upgrade Nix interpreter to current version.
+	nix/scripts/upgrade.sh
+
 nix-gc: export TARGET := nix
 nix-gc: nix-gc-protected ##@nix Garbage collect all packages older than 20 days from /nix/store
 	nix-store --gc
@@ -302,14 +306,16 @@ lint: ##@test Run code style checks
 	@sh scripts/lint-re-frame-in-quo-components.sh && \
 	clj-kondo --config .clj-kondo/config.edn --cache false --lint src && \
 	ALL_CLOJURE_FILES=$(call find_all_clojure_files) && \
-	zprint '{:search-config? true}' -sfc $$ALL_CLOJURE_FILES
+	zprint '{:search-config? true}' -sfc $$ALL_CLOJURE_FILES && \
+	yarn prettier
 
 # NOTE: We run the linter twice because of https://github.com/kkinnear/zprint/issues/271
 lint-fix: export TARGET := default
 lint-fix: ##@test Run code style checks and fix issues
 	ALL_CLOJURE_FILES=$(call find_all_clojure_files) && \
 	zprint '{:search-config? true}' -sw $$ALL_CLOJURE_FILES && \
-	zprint '{:search-config? true}' -sw $$ALL_CLOJURE_FILES
+	zprint '{:search-config? true}' -sw $$ALL_CLOJURE_FILES && \
+	yarn prettier
 
 
 shadow-server: export TARGET := clojure

babel.config.js

@@ -1,24 +1,19 @@
 module.exports = {
-
-    "presets": [
-        "module:metro-react-native-babel-preset"
-    ],
-    "plugins": [
-        "react-native-reanimated/plugin"
-    ],
-    "env": {
-        "test": {
-            "presets": [
-                '@babel/preset-react',
-                [
-                    '@babel/preset-env',
-                    {
-                        targets: {
-                            node: '14',
-                        },
-                    },
-                ],
-            ],
-        }
-    }
-}
+  presets: ['module:metro-react-native-babel-preset'],
+  plugins: ['react-native-reanimated/plugin'],
+  env: {
+    test: {
+      presets: [
+        '@babel/preset-react',
+        [
+          '@babel/preset-env',
+          {
+            targets: {
+              node: '14',
+            },
+          },
+        ],
+      ],
+    },
+  },
+};

ci/Jenkinsfile.android

@@ -4,7 +4,7 @@ library '[email protected]'
 def isPRBuild = utils.isPRBuild()
 
 pipeline {
-  agent { label 'linux && x86_64 && nix-2.11' }
+  agent { label 'linux && x86_64 && nix-2.14' }
 
   options {
     timestamps()

ci/Jenkinsfile.ios

@@ -4,7 +4,7 @@ library '[email protected]'
 def isPRBuild = utils.isPRBuild()
 
 pipeline {
-  agent { label 'macos && arm64 && nix-2.11 && xcode-14.3' }
+  agent { label 'macos && arm64 && nix-2.14 && xcode-14.3' }
 
   parameters {
     string(

ci/Jenkinsfile.tests

@@ -4,7 +4,7 @@ library '[email protected]'
 def isPRBuild = utils.isPRBuild()
 
 pipeline {
-  agent { label 'linux && x86_64 && nix-2.11' }
+  agent { label 'linux && x86_64 && nix-2.14' }
 
   options {
     timestamps()

doc/decisions/0014-wallet-team.md

@@ -0,0 +1,30 @@
+# 0014. Team-structure
+
+| Date | Tags |
+|---|---|
+| 2023-06-16 | wallet team |
+
+## Status
+
+Proposed
+
+## Context:
+
+In order to try out vertical team, which is a structure that is wanted by the company, we will be creating a wallet team within the mobile team.
+Some member of the mobile team will join the current wallet team, which is composed by developers from desktop and lead by @alaibe, on a voluntary basis.
+The responsibilities of the team are to implement the new wallet UI, with the support of the current wallet team, which will be assisting with the status-go work.
+
+## Decision
+
+Some team members have already expressed interest and some have been asked and accepted to join the wallet team, these team members are:
+
+- @rasom
+- @OmarBasem
+- @vkjr
+- @J-Son89
+- @briansztamfater
+- @smohamedjavid
+
+# Follow-up Actions
+
+- We still need 3/4 team members to join the wallet team

doc/decisions/0015-team-structure.md

@@ -0,0 +1,46 @@
+# 0014. Team-structure
+
+| Date | Tags |
+|---|---|
+| 2023-06-16 | changes in team structure |
+
+## Status
+
+Proposed/partially implemented
+
+## Context:
+
+Currently, there is only a single team lead in the mobile development team, and after a meeting with the design team, it has been identified that the mobile app lacks polishness. One of the main issues identified is a lack of oversight in certain areas. To address this problem, it has been decided to create an additional role within the team. For each section of the mobile app (communities, syncing & onboarding, activity center & shell, wallet, messaging), a person will be selected to fulfill the responsibilities outlined below.
+
+## Decision
+
+The decision is to create an additional role within the mobile development team for each section. The individuals selected for these roles will have the following responsibilities:
+
+- Ensure GitHub issues are created for new features/designs of the section.
+- Ensure issues are adequately described and linked as best as possible.
+- Ensure issues have a grooming session where other developers can provide their feedback before working on the set of issues.
+- Ensure all relevant parties are invited, such as designers, QA, Product Owner, leads, etc., as needed (including the designer who created the feature).
+- Ensure there is consensus among the developers working on the section about the decided strategy approach. Ideally, this consensus should be documented.
+- Ensure UI quality by organizing designer reviews and guaranteeing pixel perfection.
+- Ensure overall implementation is satisfactory based on the predefined requirements.
+- Ensure alignment between desktop, web, and mobile versions for the respective section in collaboration with the mobile developers and design team.
+- Act as a point of contact for the design team with respect to the section.
+- Ensure that someone goes through the designs once they are created with the respective designer.
+- Assist the design team with technical feasibility analysis and address any product concerns.
+- Facilitate the growth of the next team member into the role.
+
+The people identified for each sections are as follow:
+
+- Messaging @flexsurfer, followed by @alwx
+- Syncing & Onboarding @siddarthkay
+- Communities @ilmotta
+- Activity Center & Shell @J-Son89, followed by @Parveshdhull
+- Wallet (once the vertical team is created) @J-Son89, followed by @briansztamfater
+
+This will be a rotating post, every 4 months it will go to the next in line.
+
+The wallet team might have longer times for rotation, as stability might be more important. That's still to be decided.
+
+# Follow-up Actions
+
+- Find suitable next in line for Messaging, Onboarding, Communities

index.js

@@ -1,2 +1,2 @@
-import "node-libs-react-native/globals";
-import "./result/index.js";
+import 'node-libs-react-native/globals';
+import './result/index.js';

metro.config.js

@@ -5,15 +5,15 @@
  * @format
  */
 module.exports = {
-    transformer: {
-        getTransformOptions: async () => ({
-            transform: {
-                experimentalImportSupport: false,
-                inlineRequires: true,
-            },
-        }),
-    },
-    resolver: {
-        extraNodeModules: require('node-libs-react-native'),
-    },
+  transformer: {
+    getTransformOptions: async () => ({
+      transform: {
+        experimentalImportSupport: false,
+        inlineRequires: true,
+      },
+    }),
+  },
+  resolver: {
+    extraNodeModules: require('node-libs-react-native'),
+  },
 };

modules/react-native-status/nodejs/bindings.js

@@ -1,6 +1,5 @@
 var binary = require('@mapbox/node-pre-gyp');
 var path = require('path');
-var binding_path = binary.find(path.resolve(path.join(__dirname,'./../../../package.json')));
+var binding_path = binary.find(path.resolve(path.join(__dirname, './../../../package.json')));
 
 module.exports = require(binding_path);
-

nix/scripts/lib.sh

@@ -48,3 +48,7 @@ nix_root() {
     fi
     echo "${NIX_ROOT}"
 }
+
+nix_current_version() {
+    nix-env --version | awk '{print $3}'
+}

nix/scripts/setup.sh

@@ -3,15 +3,11 @@
 set -eo pipefail
 
 GIT_ROOT=$(cd "${BASH_SOURCE%/*}" && git rev-parse --show-toplevel)
-source "${GIT_ROOT}/nix/scripts/lib.sh"
 source "${GIT_ROOT}/scripts/colors.sh"
+source "${GIT_ROOT}/nix/scripts/lib.sh"
+source "${GIT_ROOT}/nix/scripts/version.sh"
 
-NIX_VERSION="2.11.1"
-NIX_INSTALL_URL="https://nixos.org/releases/nix/nix-${NIX_VERSION}/install"
-NIX_INSTALL_SHA256="4569a01dc5f62056f29f3195673bc3242fc70bf2474927fb5d8549c4d997402d"
-NIX_INSTALL_PATH="/tmp/nix-install-${NIX_VERSION}"
-
-install_nix() {
+nix_install() {
     # Download installer and verify SHA256>
     curl -sSf "${NIX_INSTALL_URL}" -o "${NIX_INSTALL_PATH}"
     echo "${NIX_INSTALL_SHA256}  ${NIX_INSTALL_PATH}" | sha256sum -c
@@ -72,5 +68,5 @@ fi
 
 # If none of the checks before succeeded we need to install Nix
 echo -e "${GRN}Setting up Nix package manager...${RST}"
-install_nix
+nix_install
 echo -e "${YLW}See STARTING_GUIDE.md if you're new here.${RST}"

nix/scripts/source.sh

@@ -12,7 +12,7 @@ source_nix_profile() {
         source "/nix/var/nix/profiles/default/etc/profile.d/nix-daemon.sh"
     elif [[ "${NIX_INSTALL_TYPE}" == "single" ]]; then
         source "${HOME}/.nix-profile/etc/profile.d/nix.sh"
-    elif [[ "${NIX_INSTALL_TYPE}" == "nixops" ]]; then
+    elif [[ "${NIX_INSTALL_TYPE}" == "nixos" ]]; then
         echo "Sourcing profile not necessary on NixOS!" >&2
     fi
 }