Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci_: bring back cmd coverage #6204

Merged
merged 2 commits into from
Dec 12, 2024
Merged

ci_: bring back cmd coverage #6204

merged 2 commits into from
Dec 12, 2024

Conversation

igor-sirotin
Copy link
Collaborator

  1. The way we were cutting out /cmd coverage from reports was working for Codeclimate, but doens't work for Codecov
  2. There are some tests in that directory already
  3. We do have ways to introduce tests for apps in ./cmd, e.g. with functional tests. And coverage will be measured.
  4. If some specific directory needs to be filtered out, it should be done in .codecov.yml

@igor-sirotin igor-sirotin requested a review from a team December 12, 2024 12:06
@igor-sirotin igor-sirotin requested a review from a team as a code owner December 12, 2024 12:06
@igor-sirotin igor-sirotin changed the title ci_: cmd coverage ci_: bring back cmd coverage Dec 12, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Dec 12, 2024

Jenkins Builds

Click to see older builds (8)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 0a6b661 #1 2024-12-12 12:11:06 ~4 min ios 📦zip
✔️ 0a6b661 #1 2024-12-12 12:11:12 ~4 min macos 📦zip
✔️ 0a6b661 #1 2024-12-12 12:11:21 ~4 min linux 📦zip
✔️ 0a6b661 #1 2024-12-12 12:12:14 ~5 min windows 📦zip
✔️ 0a6b661 #1 2024-12-12 12:12:55 ~6 min android 📦aar
✔️ 0a6b661 #1 2024-12-12 12:13:48 ~7 min tests-rpc 📄log
✔️ 0a6b661 #1 2024-12-12 12:15:05 ~8 min macos 📦zip
✖️ 0a6b661 #1 2024-12-12 12:37:52 ~31 min tests 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 98c2fd8 #2 2024-12-12 12:15:45 ~4 min ios 📦zip
✔️ 98c2fd8 #2 2024-12-12 12:15:52 ~4 min macos 📦zip
✔️ 98c2fd8 #2 2024-12-12 12:16:12 ~3 min windows 📦zip
✔️ 98c2fd8 #2 2024-12-12 12:16:46 ~5 min linux 📦zip
✔️ 98c2fd8 #2 2024-12-12 12:18:50 ~5 min android 📦aar
✔️ 98c2fd8 #2 2024-12-12 12:20:44 ~6 min tests-rpc 📄log
✔️ 98c2fd8 #2 2024-12-12 12:23:53 ~8 min macos 📦zip
✖️ 98c2fd8 #2 2024-12-12 13:09:02 ~31 min tests 📄log
✖️ 98c2fd8 #3 2024-12-12 13:51:11 ~31 min tests 📄log
✔️ e8f441f #3 2024-12-12 14:13:56 ~3 min windows 📦zip
✔️ e8f441f #3 2024-12-12 14:14:43 ~4 min macos 📦zip
✔️ e8f441f #3 2024-12-12 14:14:51 ~4 min ios 📦zip
✔️ e8f441f #3 2024-12-12 14:15:04 ~5 min android 📦aar
✔️ e8f441f #3 2024-12-12 14:15:23 ~5 min linux 📦zip
✔️ e8f441f #3 2024-12-12 14:16:01 ~6 min tests-rpc 📄log
✔️ e8f441f #3 2024-12-12 14:17:59 ~7 min macos 📦zip
✔️ e8f441f #4 2024-12-12 14:39:36 ~29 min tests 📄log

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.36%. Comparing base (ef177c1) to head (e8f441f).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6204      +/-   ##
===========================================
+ Coverage    61.34%   61.36%   +0.01%     
===========================================
  Files          833      833              
  Lines       109909   109909              
===========================================
+ Hits         67426    67442      +16     
+ Misses       34591    34580      -11     
+ Partials      7892     7887       -5     
Flag Coverage Δ
functional 19.56% <ø> (-0.04%) ⬇️
unit 60.05% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 38 files with indirect coverage changes

@igor-sirotin igor-sirotin merged commit 137698e into develop Dec 12, 2024
18 checks passed
@igor-sirotin igor-sirotin deleted the ci/cmd-coverage branch December 12, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants