chore_: bump go-waku fixes on peers and concurrent access #6187

plopezlpz · 2024-12-10T12:55:47Z

bump go-waku including fixes:

fix: use bad peer removal logic only for lightpush and filter and option to restart missing message verifier waku-org/go-waku#1244
fix: fatal error: concurrent map writes waku-org/go-waku#1265

status-im-auto · 2024-12-10T13:00:37Z

Jenkins Builds

Click to see older builds (16)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`6b30855`	#1	2024-12-10 13:00:36	~4 min	`windows`	📦`zip`
✔️	`6b30855`	#1	2024-12-10 13:00:59	~4 min	`linux`	📦`zip`
✔️	`6b30855`	#1	2024-12-10 13:01:57	~5 min	`ios`	📦`zip`
✔️	`6b30855`	#1	2024-12-10 13:02:11	~6 min	`android`	📦`aar`
✔️	`6b30855`	#1	2024-12-10 13:03:05	~6 min	`tests-rpc`	📄`log`
✔️	`6b30855`	#1	2024-12-10 13:03:39	~7 min	`macos`	📦`zip`
✔️	`6b30855`	#1	2024-12-10 13:05:45	~9 min	`macos`	📦`zip`
✔️	`6b30855`	#1	2024-12-10 13:27:17	~31 min	`tests`	📄`log`
✔️	`6b30855`	#3	2024-12-12 11:52:19	~2 min	`windows`	📦`zip`
✔️	`6b30855`	#3	2024-12-12 11:53:41	~4 min	`macos`	📦`zip`
✔️	`6b30855`	#3	2024-12-12 11:53:44	~4 min	`linux`	📦`zip`
✔️	`6b30855`	#3	2024-12-12 11:53:50	~4 min	`ios`	📦`zip`
✔️	`6b30855`	#3	2024-12-12 11:55:08	~5 min	`android`	📦`aar`
✖️	`6b30855`	#3	2024-12-12 11:55:18	~5 min	`tests-rpc`	📄`log`
✔️	`6b30855`	#3	2024-12-12 11:59:36	~8 min	`macos`	📦`zip`
✔️	`6b30855`	#3	2024-12-12 12:18:23	~29 min	`tests`	📄`log`

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✖️	`ce5d409`	#2	2024-12-12 11:42:34	~1 min	`tests`	📄`log`
✔️	`ce5d409`	#2	2024-12-12 11:43:55	~3 min	`windows`	📦`zip`
✔️	`ce5d409`	#2	2024-12-12 11:45:00	~4 min	`macos`	📦`zip`
✔️	`ce5d409`	#2	2024-12-12 11:45:05	~4 min	`linux`	📦`zip`
✔️	`ce5d409`	#2	2024-12-12 11:45:12	~4 min	`ios`	📦`zip`
✔️	`ce5d409`	#2	2024-12-12 11:46:09	~5 min	`android`	📦`aar`
✖️	`ce5d409`	#2	2024-12-12 11:46:30	~5 min	`tests-rpc`	📄`log`
✔️	`ce5d409`	#2	2024-12-12 11:50:39	~10 min	`macos`	📦`zip`

✔️	`49c48ae`	#4	2024-12-12 11:56:39	~2 min	`windows`	📦`zip`
✔️	`49c48ae`	#4	2024-12-12 11:58:16	~4 min	`macos`	📦`zip`
✔️	`49c48ae`	#4	2024-12-12 11:58:20	~4 min	`linux`	📦`zip`
✔️	`49c48ae`	#4	2024-12-12 11:58:39	~4 min	`ios`	📦`zip`
✔️	`49c48ae`	#4	2024-12-12 12:00:50	~5 min	`android`	📦`aar`
✖️	`49c48ae`	#4	2024-12-12 12:01:19	~5 min	`tests-rpc`	📄`log`
✔️	`49c48ae`	#4	2024-12-12 12:06:39	~6 min	`macos`	📦`zip`
✖️	`49c48ae`	#4	2024-12-12 12:20:00	~1 min	`tests`	📄`log`
✖️	`49c48ae`	#5	2024-12-12 14:59:01	~1 min	`tests`	📄`log`
✔️	`49c48ae`	#5	2024-12-12 14:59:59	~2 min	`windows`	📦`zip`
✖️	`49c48ae`	#6	2024-12-12 15:01:13	~1 min	`tests`	📄`log`
✔️	`49c48ae`	#5	2024-12-12 15:01:34	~4 min	`macos`	📦`zip`
✔️	`49c48ae`	#5	2024-12-12 15:01:39	~4 min	`linux`	📦`zip`
✔️	`49c48ae`	#5	2024-12-12 15:02:31	~5 min	`android`	📦`aar`
✔️	`49c48ae`	#6	2024-12-12 15:03:01	~2 min	`windows`	📦`zip`
✖️	`49c48ae`	#5	2024-12-12 15:03:04	~5 min	`tests-rpc`	📄`log`
✔️	`49c48ae`	#5	2024-12-12 15:03:13	~6 min	`ios`	📦`zip`
✔️	`49c48ae`	#5	2024-12-12 15:04:59	~7 min	`macos`	📦`zip`
✔️	`49c48ae`	#6	2024-12-12 15:05:59	~4 min	`macos`	📦`zip`
✔️	`49c48ae`	#6	2024-12-12 15:06:36	~4 min	`linux`	📦`zip`
✖️	`49c48ae`	#6	2024-12-12 15:07:20	~4 min	`tests-rpc`	📄`log`
✔️	`49c48ae`	#6	2024-12-12 15:07:48	~5 min	`android`	📦`aar`
✔️	`49c48ae`	#6	2024-12-12 15:08:00	~4 min	`ios`	📦`zip`
✔️	`49c48ae`	#6	2024-12-12 15:12:59	~7 min	`macos`	📦`zip`

plopezlpz · 2024-12-10T13:26:36Z

[blocked]: cannot merge up until this is merged:
#5964

codecov · 2024-12-10T13:27:39Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.00%. Comparing base (e6c2f89) to head (49c48ae).
Report is 3 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #6187      +/-   ##
===========================================
+ Coverage    13.89%   14.00%   +0.10%     
===========================================
  Files          817      817              
  Lines       108311   108311              
===========================================
+ Hits         15055    15164     +109     
+ Misses       91333    91218     -115     
- Partials      1923     1929       +6

Flag	Coverage Δ
functional	`14.00% <ø> (+0.10%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes

richard-ramos

LGTM.
~~Do you know if waku-org/go-waku#1244 been tested?~~
EDIT: just saw the comment above!

richard-ramos · 2024-12-10T14:19:36Z

Assuming we can't get waku-org/go-waku#1244 tested & merged, we could try to create a branch in go-waku for 0.32 and only include the changes from waku-org/go-waku#1265
IMO we should include this change as a concurrent map write will likely end up with the app crashing and the fix is very straightfwd. Wdyt, @chaitanyaprem

cc: @churik @anastasiyaig

anastasiyaig · 2024-12-11T14:01:34Z

@richard-ramos can the issues mentioned in this PR cause crashes?

richard-ramos · 2024-12-11T14:47:32Z

@anastasiyaig: can the issues mentioned in this PR cause crashes?

This one can: waku-org/go-waku#1265 although it seems to happen rarely

richard-ramos · 2024-12-11T15:04:27Z

This one can: waku-org/go-waku#1265 although it seems to happen rarely

@anastasiyaig @churik
Reason why I say that it's rare for this error to happen is because this issue that was introduced 2 months ago in status-go develop branch as it can be seen in this commit yet I have not seen this crash being reported before.

anastasiyaig · 2024-12-11T15:07:24Z

thats why i ask, i did not face with this issue at all recently :)

churik · 2024-12-12T10:04:42Z

So we have status-im/status-mobile#21799 (comment) based on this comment I suppose it might be the solution to this problem, right?

@richard-ramos can you please clarify the regression area for these fixes, what might be affected?

Based on description, I'd say app state on network conditions (online/offline/cellular) + fetching messages should work the same.

richard-ramos · 2024-12-12T11:53:02Z

@churik: can you please clarify the regression area for these fixes, what might be affected?

fix: fatal error: concurrent map writes waku-org/go-waku#1265 - the affected areas were those that involve doing a store query.
fix: concurrent peerMap iteration and write waku-org/go-waku#1266 - the affected areas were those that had interactions with waku protocols, due to this code being used to select peers (to subscribe to filter nodes, store queries, publish messages, etc)
fix: use bad peer removal logic only for lightpush and filter and option to restart missing message verifier waku-org/go-waku#1244 - see PR description (fixes a lot of issues related to filter and lightpush)

churik · 2024-12-12T14:49:08Z

@richard-ramos can we rebase it to release/7.1.x and update it in mobile PR?
explanation is in status-im/status-mobile#21809 (comment)

richard-ramos · 2024-12-12T14:52:17Z

cc-ing: @plopezlpz as he is the owner of this PR 🚀

ilmotta · 2024-12-12T15:10:48Z

@plopezlpz could you force a commit hash change in this PR while also changing it to point to the release branch release/7.1.x? The script on mobile that grabs the status-go source zip is still pointing to the same hash even when the base branch changed in this PR. We just want to be sure the new mobile build actually uses the new code introduced from the change of base. Thank you!

Nevermind @plopezlpz I created a duplicate PR for mobile to experiment.

plopezlpz · 2024-12-12T15:32:26Z

@ilmotta @churik @richard-ramos
I've created this one: #6209
It includes only the two fixes for concurrent map access panic

chore_: bump go-waku fixes on peers and concurrent access

6b30855

plopezlpz requested review from richard-ramos, chaitanyaprem and igor-sirotin December 10, 2024 12:56

plopezlpz requested review from osmaczko and kaichaosun December 10, 2024 13:14

plopezlpz marked this pull request as draft December 10, 2024 13:27

richard-ramos approved these changes Dec 10, 2024

View reviewed changes

kaichaosun approved these changes Dec 11, 2024

View reviewed changes

osmaczko approved these changes Dec 11, 2024

View reviewed changes

churik mentioned this pull request Dec 11, 2024

Random crashes throughout the app status-im/status-mobile#21798

Open

qfrank force-pushed the fix/bump-go-waku branch from ce5d409 to 6b30855 Compare December 12, 2024 11:49

chore_: include an extra fix for peerMap

49c48ae

qfrank mentioned this pull request Dec 12, 2024

chore_: bump go-waku fixes on peers and concurrent access status-im/status-mobile#21809

Closed

plopezlpz marked this pull request as ready for review December 12, 2024 14:56

plopezlpz changed the base branch from develop to release/7.1.x December 12, 2024 14:56

plopezlpz changed the base branch from release/7.1.x to develop December 12, 2024 14:59

vkjr mentioned this pull request Dec 13, 2024

Random freezes throughout the app (Android) status-im/status-mobile#21799

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore_: bump go-waku fixes on peers and concurrent access #6187

chore_: bump go-waku fixes on peers and concurrent access #6187

plopezlpz commented Dec 10, 2024

status-im-auto commented Dec 10, 2024 •

edited

Loading

plopezlpz commented Dec 10, 2024

codecov bot commented Dec 10, 2024 •

edited

Loading

richard-ramos left a comment •

edited

Loading

richard-ramos commented Dec 10, 2024

anastasiyaig commented Dec 11, 2024

richard-ramos commented Dec 11, 2024 •

edited

Loading

richard-ramos commented Dec 11, 2024

anastasiyaig commented Dec 11, 2024

churik commented Dec 12, 2024

richard-ramos commented Dec 12, 2024

churik commented Dec 12, 2024

richard-ramos commented Dec 12, 2024

ilmotta commented Dec 12, 2024 •

edited

Loading

plopezlpz commented Dec 12, 2024

chore_: bump go-waku fixes on peers and concurrent access #6187

Are you sure you want to change the base?

chore_: bump go-waku fixes on peers and concurrent access #6187

Conversation

plopezlpz commented Dec 10, 2024

status-im-auto commented Dec 10, 2024 • edited Loading

Jenkins Builds

plopezlpz commented Dec 10, 2024

codecov bot commented Dec 10, 2024 • edited Loading

Codecov Report

richard-ramos left a comment • edited Loading

Choose a reason for hiding this comment

richard-ramos commented Dec 10, 2024

anastasiyaig commented Dec 11, 2024

richard-ramos commented Dec 11, 2024 • edited Loading

richard-ramos commented Dec 11, 2024

anastasiyaig commented Dec 11, 2024

churik commented Dec 12, 2024

richard-ramos commented Dec 12, 2024

churik commented Dec 12, 2024

richard-ramos commented Dec 12, 2024

ilmotta commented Dec 12, 2024 • edited Loading

plopezlpz commented Dec 12, 2024

status-im-auto commented Dec 10, 2024 •

edited

Loading

codecov bot commented Dec 10, 2024 •

edited

Loading

richard-ramos left a comment •

edited

Loading

richard-ramos commented Dec 11, 2024 •

edited

Loading

ilmotta commented Dec 12, 2024 •

edited

Loading