bug_: fix resend type for private group messages #5258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (32)
|
cammellos
force-pushed
the
bug/send-private-group-chat-messages-as-datasync
branch
2 times, most recently
from
a7a8879
to
c6326cb
Compare
cammellos
force-pushed
the
bug/send-private-group-chat-messages-as-datasync
branch
from
c6326cb
to
1d4aca3
Compare
ilmotta
reviewed
May 29, 2024
| @@ -288,6 +288,14 @@ func (c *Chat) IsActivePersonalChat() bool { | |||
| return c.Active && (c.OneToOne() || c.PrivateGroupChat() || c.Public()) && c.CommunityID == "" | |||
| } | |||
|
|
|||
| func (c *Chat) DefaultResendType() common.ResendType { | |||
There was a problem hiding this comment.
@cammellos, the function protocol#GetResendTypeForChat seems to be a duplicate of this new function you just defined. Shouldn't the places GetResendTypeForChat is called also use the new implementation you defined that caters for private group chats? If so, probably better would be to remove/replace GetResendTypeForChat with your DefaultResendType?
There was a problem hiding this comment.
oh yes, I didn't notice it was already there, I assumed it wasn't, I'll use mine since it's tested :)
cammellos
force-pushed
the
bug/send-private-group-chat-messages-as-datasync
branch
from
1d4aca3
to
0ea97e6
Compare
ilmotta
approved these changes
May 29, 2024
igor-sirotin
approved these changes
May 29, 2024
cammellos
force-pushed
the
bug/send-private-group-chat-messages-as-datasync
branch
2 times, most recently
from
6021959
to
a332809
Compare
cammellos
force-pushed
the
bug/send-private-group-chat-messages-as-datasync
branch
from
a332809
to
5b17234
Compare
jo-mut
pushed a commit
that referenced
this pull request
May 30, 2024
* chore_: bump go-waku * fix_: fix resend type for private group messages --------- Co-authored-by: Richard Ramos <[email protected]>
This was referenced May 30, 2024
jo-mut
pushed a commit
that referenced
this pull request
May 30, 2024
cammellos
added a commit
that referenced
this pull request
May 30, 2024
--------- Co-authored-by: Richard Ramos <[email protected]>
cammellos
added a commit
that referenced
this pull request
May 30, 2024
--------- Co-authored-by: Richard Ramos <[email protected]>
jo-mut
added a commit
that referenced
this pull request
May 30, 2024
--------- Co-authored-by: Andrea Maria Piana <[email protected]> Co-authored-by: Richard Ramos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resend type was wrong for private group chats, leading for those messages not being retried anymore after coming back online.