Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Empty community tags in always empty slice, not nil #4420

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Fix: Empty community tags in always empty slice, not nil #4420

merged 1 commit into from
Dec 8, 2023

Conversation

MishkaRogachev
Copy link
Contributor

For status-im/status-desktop#12822

Important changes:

  • Empty community tags in always empty slice, not nil

@status-im-auto
Copy link
Member

status-im-auto commented Dec 5, 2023 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 53b63ec #1 2023-12-05 10:45:35 ~3 min linux 📦zip
✔️ 53b63ec #1 2023-12-05 10:46:55 ~5 min ios 📦zip
✔️ 53b63ec #1 2023-12-05 10:47:53 ~6 min android 📦aar
✔️ 53b63ec #1 2023-12-05 11:17:23 ~35 min tests 📄log

@MishkaRogachev MishkaRogachev mentioned this pull request Dec 5, 2023
Closed
@MishkaRogachev MishkaRogachev merged commit 238a6e2 into develop Dec 8, 2023
2 checks passed
@MishkaRogachev MishkaRogachev deleted the fix/share-urls-community-tags branch December 8, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mprakhov mprakhov mprakhov approved these changes

@igor-sirotin igor-sirotin igor-sirotin approved these changes

@borismelnik borismelnik Awaiting requested review from borismelnik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MishkaRogachev @status-im-auto @igor-sirotin @mprakhov