-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add option to preserve history on chat delete #4324
Conversation
Hey @BalogunofAfrica, and thank you so much for making your first pull request in status-go! ❤️ Please help us make your experience better by filling out this brief questionnaire https://goo.gl/forms/uWqNcVpVz7OIopXg2 |
Jenkins BuildsClick to see older builds (15)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I assume PreserveHistory
defaults at false, so if we want the same behaviour on desktop, we need to explicitly pass it at true
?
Yes |
b7dea3a
to
f663caf
Compare
e0364de
to
305e86c
Compare
305e86c
to
79cdfed
Compare
79cdfed
to
dea05b2
Compare
The
Delete Chat
action was updated toClose Chat
which is meant to preserve history. This PR adds the option to preserve the history when callingDeactivateChat
.Related mobile issue: status-im/status-mobile#17912