Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add option to preserve history on chat delete #4324

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

BalogunofAfrica
Copy link
Contributor

@BalogunofAfrica BalogunofAfrica commented Nov 15, 2023

The Delete Chat action was updated to Close Chat which is meant to preserve history. This PR adds the option to preserve the history when calling DeactivateChat.

Related mobile issue: status-im/status-mobile#17912

@ghost
Copy link

ghost commented Nov 15, 2023

Hey @BalogunofAfrica, and thank you so much for making your first pull request in status-go! ❤️ Please help us make your experience better by filling out this brief questionnaire https://goo.gl/forms/uWqNcVpVz7OIopXg2

@status-im-auto
Copy link
Member

status-im-auto commented Nov 15, 2023

Jenkins Builds

Click to see older builds (15)
Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ b7dea3a #1 2023-11-15 13:00:58 ~2 min tests 📄log
✔️ b7dea3a #1 2023-11-15 13:01:57 ~3 min linux 📦zip
✔️ b7dea3a #1 2023-11-15 13:03:37 ~5 min android 📦aar
✔️ b7dea3a #1 2023-11-15 13:08:17 ~10 min ios 📦zip
✔️ f663caf #2 2023-11-24 11:43:57 ~3 min ios 📦zip
✔️ f663caf #2 2023-11-24 12:33:17 ~52 min linux 📦zip
✖️ f663caf #2 2023-11-24 12:38:33 ~58 min tests 📄log
✖️ e0364de #3 2023-12-01 12:24:49 ~2 min tests 📄log
✔️ e0364de #3 2023-12-01 12:26:08 ~3 min linux 📦zip
✔️ e0364de #3 2023-12-01 12:27:01 ~4 min ios 📦zip
✔️ e0364de #3 2023-12-01 12:28:06 ~5 min android 📦aar
✔️ 305e86c #4 2023-12-04 12:38:31 ~1 min linux 📦zip
✖️ 305e86c #4 2023-12-04 12:39:07 ~2 min tests 📄log
✔️ 305e86c #4 2023-12-04 12:41:53 ~5 min ios 📦zip
✔️ 305e86c #4 2023-12-04 12:42:12 ~5 min android 📦aar
Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ 79cdfed #5 2023-12-08 12:34:01 ~1 min tests 📄log
✔️ 79cdfed #5 2023-12-08 12:35:17 ~2 min android 📦aar
✔️ 79cdfed #5 2023-12-08 12:36:00 ~3 min ios 📦zip
✔️ 79cdfed #5 2023-12-08 12:36:04 ~3 min linux 📦zip
✖️ 79cdfed #6 2023-12-08 16:24:32 ~1 min tests 📄log
✔️ dea05b2 #6 2023-12-08 17:16:05 ~1 min linux 📦zip
✔️ dea05b2 #6 2023-12-08 17:16:15 ~1 min android 📦aar
✔️ dea05b2 #6 2023-12-08 17:17:18 ~2 min ios 📦zip
✖️ dea05b2 #7 2023-12-08 17:48:40 ~34 min tests 📄log
✔️ dea05b2 #8 2023-12-11 10:39:22 ~37 min tests 📄log
✖️ dea05b2 #9 2023-12-11 10:55:49 ~16 min tests 📄log
✖️ dea05b2 #10 2023-12-11 11:12:49 ~16 min tests 📄log
✔️ dea05b2 #11 2023-12-11 11:51:23 ~32 min tests 📄log

@BalogunofAfrica BalogunofAfrica self-assigned this Nov 15, 2023
Copy link
Member

@jrainville jrainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I assume PreserveHistory defaults at false, so if we want the same behaviour on desktop, we need to explicitly pass it at true?

@BalogunofAfrica
Copy link
Contributor Author

BalogunofAfrica commented Nov 15, 2023

LGTM. I assume PreserveHistory defaults at false, so if we want the same behaviour on desktop, we need to explicitly pass it at true?

Yes

@BalogunofAfrica BalogunofAfrica merged commit 1b8b53b into develop Dec 11, 2023
7 checks passed
@BalogunofAfrica BalogunofAfrica deleted the fix/deactivate-chat branch December 11, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants