-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update UI to use the new CreateShareURL api #10852
Comments
@felicio Normal OG images. The new dynamic card will be done in this task #10585 which will be done by the UI team instead.
Just to be sure I understand your point/question, you're saying that when using a link outside the app (website or QR), if it's a community that you're not member of, it will open the community in spectate mode. If it's a chat key of a non-contact, it will open the profile? If that's so, then point 1 about community is already done and included. I guess I could add a point to make sure it still works. The second point about opening the profile, I'm not sure. I don't think I tested it, but it should be simple enough to do. Anyway, I don't think it's worth adding to this particular issue. This issue is for adapting to the status-go backend that will be done in #10851 If anything, most new features will come with the UI issue #10585 I'll still add an issue for opening the profile of a non-contact when using a link. If it's already done, then nothing lost, otherwise, we'll implement it. Like I said, it shouldn't be too hard since all the pieces are already there. (issue opened #10892) |
Correct.
Perfect, I think it makes sense to ensure these vacp2p/rfc#602 (comment) formats would be handled.
Nice, thank you. So far none of these work for me,
Community:
Channel:
User:
|
Yeah, that's gonna be so until we we do the #10851 Though we could support the ENS name as part of an other issue. |
@felicio question though, in you comment, you say Which one is the wanted one? Right now, we support slash more easily, but we'll need to support hashtags soon too anyway |
I understand why the encoded ones aren't working, but I'm surprised even the plain ones like the following don't.
Since I thought you said they would. Note, that these are just for demo of current implementation (not) working. |
Right, edited the comment. |
Issue for the ENS #10907 |
I tested the community and user one on Windows one or two weeks ago when I changed the prefix to status-app and they worked. Which OS are you on? Deep links don't work on Linux yet. Mac, I'm not sure. I heard that they might be broken. @borismelnik is gonna fix if that,s the case as part of the task to change to status-app as well |
Might be due to PK serialization 🤔. |
Cool.
macOS. And Status Desktop v0.12.0.
Nice. |
Description
Dependent on #10851
Anywhere we still use direct uses of
status.app/
, replace by using the status-go function and its return.Also update the MessageLinkComponent to unfurl on those new link formats.
This will need to use the new API to "decrypt" the URL or the new message properties if the URL is decrypted "automatically" when handling messages.
Acceptance Criteria
The text was updated successfully, but these errors were encountered: