-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed double sending of onTextChange events #365
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkjr
changed the title
[WIP]Fixed double sending of onTextChange events
Fixed double sending of onTextChange events
Oct 8, 2018
maxhora
approved these changes
Oct 8, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
vkjr
force-pushed
the
fix/textinput_events
branch
2 times, most recently
from
October 9, 2018 12:41
c571cf7
to
ab71b8c
Compare
Awesome ! What's wrong with the circle ci ? |
@yenda, we have one of standard |
rasom
approved these changes
Oct 17, 2018
vkjr
force-pushed
the
fix/textinput_events
branch
from
October 19, 2018 10:51
c41cee5
to
1b56660
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two TextInput bugs fixed:
defaultValue
changed.PR to check in status-react: status-im/status-mobile#6176
Here is a code that reveals second problem in js: