[WIP, don't merge] outline flow of rest of the attestation aggregation #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zah
reviewed
Jan 7, 2020
| fromNow = shortLog(fromNow), | ||
| cat = "scheduling" | ||
|
|
||
| await sleepAsync(fromNow) |
There was a problem hiding this comment.
This seems to assume that the current time when this line is reached is exactly attestationStart.offset? What ensures that this is the case? If not, the waiting here will take us to a target time that differs from the 2/3 of the slot moment.
There was a problem hiding this comment.
This is a concern, yes.
|
To clarify this PR's situation -- it's waiting on native libp2p to stabilize. |
|
#122 tracks some of these native libp2p issues. |
|
Closing in favor of upcoming PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An existence proof of the availability of the rest of how to this within
nim-beacon-chain. Obviously needs refactoring, testing, etc.It's correct but not optimal to ask to aggregate everything and only send when there's a value to the
option. That's why it's set up that way. Not good approach, but surprisingly not-terribly-wrong either.