New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VC/NIMBUS-BN validators protection. #6329

Merged

tersec merged 8 commits into unstable from vc-bn-protection

Jun 11, 2024

Contributor

cheatfate commented Jun 7, 2024

No description provided.

cheatfate added 2 commits

June 6, 2024 04:34


          Beacon node side implementation.

36f3ae3


          Validator client side implementation.

f97956f

tersec reviewed

View reviewed changes

beacon_chain/gossip_processing/eth2_processor.nim Outdated Show resolved Hide resolved

tersec reviewed

View reviewed changes

beacon_chain/gossip_processing/eth2_processor.nim Outdated Show resolved Hide resolved

github-actions bot commented Jun 7, 2024 •

edited

Loading

Unit Test Results

        9 files ±0   1 325 suites ±0 33m 8s ⏱️ - 2m 44s
  4 986 tests ±0   4 638 ✔️ ±0 348 💤 ±0 0 ❌ ±0
20 814 runs ±0 20 410 ✔️ ±0 404 💤 ±0 0 ❌ ±0

Results for commit e628336. ± Comparison against base commit f97703e.

♻️ This comment has been updated with latest results.


          Address review comments and fix the test.

b53f5bd

arnetheduck reviewed

View reviewed changes

beacon_chain/validator_client/api.nim

@@ @@ -1597,10 +1678,10 @@ proc submitPoolSyncCommitteeSignature*( @@
                       of 200:
                         ApiResponse[bool].ok(true)
                       of 400:
-                        handle400()
+                        handle400Indexed()

Member

arnetheduck Jun 7, 2024

we should not have this checking on the sync committee

Contributor Author

cheatfate Jun 7, 2024

This template and call is supposed to fix error decoding process, because both calls:
https://ethereum.github.io/beacon-APIs/#/Beacon/submitPoolAttestations and https://ethereum.github.io/beacon-APIs/#/Beacon/submitPoolSyncCommitteeSignatures

are using IndexedErrorMessage instead of ErrorMessage


          Only 400 errors could be IndexedErrorMessage, 500 errors are always E…

aaae29f

…rrorMessage.

tersec reviewed

View reviewed changes

beacon_chain/validator_client/api.nim Outdated Show resolved Hide resolved

tersec reviewed

View reviewed changes

beacon_chain/validator_client/block_service.nim Outdated Show resolved Hide resolved

tersec reviewed

View reviewed changes

beacon_chain/validator_client/api.nim Outdated Show resolved Hide resolved

tersec reviewed

View reviewed changes

beacon_chain/gossip_processing/eth2_processor.nim Outdated Show resolved Hide resolved

tersec reviewed

View reviewed changes

beacon_chain/gossip_processing/eth2_processor.nim Outdated Show resolved Hide resolved

cheatfate added 3 commits

June 7, 2024 16:27


          Remove VC shutdown functionality.

3c6e9cf


          Remove magic constants.

4a17516


          Make arguments more visible and disable default values.

290d059

tersec reviewed

View reviewed changes

beacon_chain/validators/validator_pool.nim Show resolved Hide resolved

tersec reviewed

View reviewed changes

beacon_chain/validators/validator_pool.nim Outdated Show resolved Hide resolved


          Address review comments.

e628336

tersec approved these changes

View reviewed changes

tersec merged commit 2766429 into unstable

15 checks passed

tersec deleted the vc-bn-protection branch

June 11, 2024 19:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet