Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use correct decimal or hex encoding/decoding for REST GetSpec #5371

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Conversation

tersec
Copy link
Contributor

@tersec tersec commented Aug 30, 2023

#5362

https://github.com/ethereum/beacon-APIs/blob/v2.4.2/apis/config/spec.yaml describes that

                  Values are returned with following format:
                    - any value starting with 0x in the spec is returned as a hex string
                    - numeric values are returned as a quoted integer

@github-actions
Copy link

Unit Test Results

         9 files  ±0    1 077 suites  ±0   37m 16s ⏱️ +18s
  3 725 tests ±0    3 446 ✔️ ±0  279 💤 ±0  0 ±0 
15 880 runs  ±0  15 575 ✔️ ±0  305 💤 ±0  0 ±0 

Results for commit ba13efc. ± Comparison against base commit f2d3859.

@tersec
Copy link
Contributor Author

tersec commented Aug 30, 2023

See also #5370, a slightly different take on the same idea

@zah zah merged commit 6c42cfa into unstable Aug 30, 2023
@zah zah deleted the upg branch August 30, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants