allow initializing test DBs from later forks #5186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running `makeTestDB` in tests currently always initializes DB with a `phase0` state, preventing tests that configure a fork schedule that starts in a different fork from working properly. Fix that by upgrading the genesis state to whatever fork the fork schedule starts with.
tersec
reviewed
Jul 12, 2023
tests/testdbutil.nim
Outdated
|
|
||
| # Override Eth1Data on request, skipping the lengthy Eth1 voting process | ||
| if eth1Data.isOk: | ||
| withState(genState[]): | ||
| forkyState.data.eth1_data = eth1Data.get | ||
| forkyState.root = hash_tree_root(forkyState.data) | ||
|
|
||
| # Upgrade genesis state to later fork, if not starting at Phase0 |
There was a problem hiding this comment.
Is the intent here indeed just to update the state to newer forks, not to have this happen naturally by running through enough slots to trigger the maybeUpgradeState organically?
ethereum/consensus-specs#2902 means this can produce odd effects in general, though for this purpose, it should be fine -- if there are no attestations or similar from before it upgrades forks, then there's nothing to get rejected by the fork-dependent signature checks.
There was a problem hiding this comment.
This is for the genesis state (slot == 0), e.g., starting at bellatrix
There was a problem hiding this comment.
Adjusted it so that fork.previous_version == fork.current_version in that case, e.g., both set to Bellatrix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
makeTestDBin tests currently always initializes DB with aphase0state, preventing tests that configure a fork schedule that starts in a different fork from working properly. Fix that by upgrading the genesis state to whatever fork the fork schedule starts with.