Revert "include small dedup in block processor to handle blockByRoot blocks"

[tersec]

Reverts #4814

Syncing was broken with this: status-im/infra-nimbus#132 (comment)

[jakubgs]

As far as I can tell this fixes the bug introduced by #4814 based on investigation in:

• Research alternatives to Hetzner for testnet hosting infra-nimbus#132

Result after building this version:

[email protected]:~ % for port in $(seq 9304 9305); do c 0:$port/eth/v1/node/syncing | jq -c; done
{"data":{"head_slot":"6257820","sync_distance":"0","is_syncing":false,"is_optimistic":false}}
{"data":{"head_slot":"6257820","sync_distance":"0","is_syncing":false,"is_optimistic":false}}

[email protected]:~ % for port in $(seq 9304 9305); do c 0:$port/eth/v1/node/version | jq -c; done
{"data":{"version":"Nimbus/v23.3.2-75be7d-stateofus"}}
{"data":{"version":"Nimbus/v23.3.2-751d9d-stateofus"}}

Seems to be syncing fine.

[github-actions]

Unit Test Results

         6 files   -        3       714 suites   - 357   21m 34s ⏱️ - 9m 51s
  3 360 tests  -    310    3 339 ✔️  -      52  21 💤  - 258  0 ❌ ±0 
10 438 runs   - 5 215  10 396 ✔️  - 4 952  42 💤  - 263  0 ❌ ±0 

Results for commit 6696c8f. ± Comparison against base commit 0fc8948.

[arnetheduck]

hm, weird - any idea how this breaks sync?

[tersec]

hm, weird - any idea how this breaks sync?

#4850 -- backpressure stall. The early exit didn't do any kind of future completion, which stalls request/sync managers.