encapsulate LC data variables into single structure #3777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combines the LC data configuration options (serve / importMode), the callbacks (finality / optimistic LC update) as well as the cache storing light client data, into a new `LightClientDataStore` structure. Also moves the structure into a light client specific file.
arnetheduck
reviewed
Jun 22, 2022
| @@ -79,3 +79,26 @@ type | |||
|
|
|||
| importTailSlot*: Slot | |||
| ## The earliest slot for which light client data is imported. | |||
|
|
|||
| LightClientDataStore* = object | |||
There was a problem hiding this comment.
technically, this is a "light server" store
There was a problem hiding this comment.
Yeah, haha, but that terminology is nowhere used yet, so sticking with "light client data" for now (technically, a client could also cache the obtained data and then provide it to others, or use it to roll-back in case it fails to advance when there is no supermajority, so use case of this data is not limited to just server)
arnetheduck
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combines the LC data configuration options (serve / importMode), the
callbacks (finality / optimistic LC update) as well as the cache storing
light client data, into a new
LightClientDataStorestructure.Also moves the structure into a light client specific file.