Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
integrate light client into beacon node #3557
integrate light client into beacon node #3557
Changes from 6 commits
c337959
ecb1703
e7e552d
d0a5dfc
f6385ab
43876fc
cfbb229
1eb2e18
64ecc18
0d7c822
24e77a9
ef98183
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this
Option
/applyConfigDefault
help?nimbus-eth2/beacon_chain/nimbus_beacon_node.nim
Lines 1699 to 1709 in 43876fc
show the mechanism, but it's not clear to me why this version (see also
lightClientTrustedBlockRoot
) is better than the more straightforwardOption
-free variation which sets some appropriate default and avoids theOption
-.get()
indirection.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had it at default-on for kiln/ropsten/prater, but you are right that now with the default off the straight-forward
bool
would also work. I guess when optimistic sync is fully implemented, that this would need to be changed to detect the case of "no user preference" vs "user selected off" and apply network specific default in first case. I can get rid of it once more and it can then be reintroduced later, or we can just keep it as is, up to you.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, keep as is.