Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump libp2p #3438

Merged
merged 1 commit into from
Feb 25, 2022
Merged

Bump libp2p #3438

merged 1 commit into from
Feb 25, 2022

Conversation

Menduist
Copy link
Contributor

This bump includes:

@Menduist Menduist enabled auto-merge (squash) February 25, 2022 10:46
except CatchableError:
gossipId(m.data, altairPrefix, topic, false)
ok(gossipId(m.data, altairPrefix, topic, false))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can reject with penalty here - it's junk data and keeping it in the message caches isn't going to make anyone happy - it also means we can remove the false path from gossipId

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like for the bump to only bump, and not change this behavior
We can do that in a later PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mm .. with strict exception checking, we can probably get rid of some exception handlers as well which is nice

@Menduist Menduist merged commit 1bfbcc4 into unstable Feb 25, 2022
@Menduist Menduist deleted the bumplibp2p branch February 25, 2022 12:22
@github-actions
Copy link

Unit Test Results

     12 files  ±0     821 suites  ±0   33m 46s ⏱️ - 3m 4s
1 671 tests ±0  1 625 ✔️ ±0    46 💤 ±0  0 ±0 
9 755 runs  ±0  9 655 ✔️ ±0  100 💤 ±0  0 ±0 

Results for commit 4f23049. ± Comparison against base commit c29aa9d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants