Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak unstable (std/random missing after dup validator protection) #2255

Merged
merged 1 commit into from
Jan 21, 2021

Conversation

mratsim
Copy link
Contributor

@mratsim mratsim commented Jan 21, 2021

Btw is there a reason to use Nim's std/random instead of the Nimbus-wide (cryptographic) RNG?

@mratsim mratsim requested review from zah and tersec January 21, 2021 16:55
@tersec
Copy link
Contributor

tersec commented Jan 21, 2021

I removed the stdlib random import in #2240 and it seems to have worked there, but for some reason it broke later. There's not a compelling reason to use the stdlib random in nimbus_beacon_node, no, but it's more important to unbreak unstable.

@mratsim mratsim merged commit 718feef into unstable Jan 21, 2021
@mratsim mratsim deleted the unbreak-unstable branch January 21, 2021 17:27
@mratsim mratsim mentioned this pull request Jan 21, 2021
@zah
Copy link
Contributor

zah commented Jan 21, 2021

Hmm, I wonder how the previous PR passed CI. I've pushed a follow-up commit that removes std/random again here:
960666d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants