BLSCurve EIP2333 updates for Spadina (breaks old keystore recovery) #1742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps NBC to integrate status-im/nim-blscurve#87
EIP2333 has been updated with a slightly modified way to derive (private, public) keypairs from a master key ethereum/EIPs#2985. This includes derivation of the withdrawal key (which cannot be used for phase 0 anyway).
This slightly modified way follows cryptographers recommendations to prevent zero secret keys in BLS draft v4 which is planned for future release in Eth2.0 ethereum/consensus-specs#2072
Concretely, keypairs generated with the old CLI cannot be recovered from the mnemonic/master key.
A workaround would be to checkout an old commit (should we use a tag before merging this PR?) for re-derivation of keypairs