Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for finalizing chain! #162

Merged
merged 1 commit into from
Mar 9, 2019
Merged

Updates for finalizing chain! #162

merged 1 commit into from
Mar 9, 2019

Conversation

arnetheduck
Copy link
Member

* set epoch_boundary_root - chain finalizes!
* fix slotStart to offset GENESIS_SLOT
* work around bug that will be fixed by
ethereum/consensus-specs#732
* compile with debug info (there was a GC-related crash in C land)
@arnetheduck
Copy link
Member Author

after this branch, invalid blocks are sometimes proposed - I suspect the shuffling off-by-one that will be fixed with ethereum/consensus-specs#732

Copy link
Contributor

@tersec tersec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tersec tersec merged commit aec31b1 into master Mar 9, 2019
@delete-merged-branch delete-merged-branch bot deleted the set-epoch-boundary branch March 9, 2019 04:23
mratsim added a commit that referenced this pull request Mar 20, 2019
and ethereum/consensus-specs#732 epoch transition work around
etan-status pushed a commit that referenced this pull request May 12, 2022
Add more respond() aliases.
Add responded() to check if response is already sent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants