assert on missing active validators' attestations when verifying finalization #1387
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along the lines of #1386, but where that one shouldn't flag any conditions that wouldn't already (an epoch later) have triggered finalization failure, this tightens the requirements the 2/3 balance quorum, to being able not to receive only 10 of the testnet0/testnet1) 128 active validators' attestations. 8 of those will already come from some validators programmed not to attest, so that leaves a tolerance currently of 3 validators allowed not to attest without this firing.
So, this is quite a tighter check on the interactions between nbc and libp2p losing track of attestations in the context of justification and finalization.