Fork choice fixes 2 #1356
Fork choice fixes 2 #1356
Conversation
* enable v2 pruning * prefer `get_current_epoch` * fix finalization check to use correct epoch
* add `count_active_validators` * remove misleading logs * fix justified checkpoint slot calculation in rpc
| @@ -56,6 +56,12 @@ func is_active_validator*(validator: Validator, epoch: Epoch): bool = | |||
| ### Check if ``validator`` is active | |||
| validator.activation_epoch <= epoch and epoch < validator.exit_epoch | |||
|
|
|||
| # https://github.com/ethereum/eth2.0-specs/blob/v0.12.1/specs/phase0/beacon-chain.md#get_active_validator_indices | |||
There was a problem hiding this comment.
It's a fine abstraction, but still not something one would want to call that often, for the same reasons that get_active_validator_indices() is not great to call often.
There was a problem hiding this comment.
Also, as an isolated function, just count_active_validators() captures the idea fine, as a name. There is, though, a case for the symmetry between {get,count}_active_validator_indices(). Subjective and to taste.
There was a problem hiding this comment.
hm, yeah, I suspect there may be tricks to get rid of it - until then, it's a trivial addition that simplifies some code
There was a problem hiding this comment.
It also avoids memory allocations, which is probably much of what's left outside BLS cryptography.
| func populateEpochCache(state: BeaconState, epoch: Epoch): EpochRef = | ||
| (EpochRef)( | ||
| epoch: state.slot.compute_epoch_at_slot, | ||
| func populateEpochCache(state: BeaconState): EpochRef = |
There was a problem hiding this comment.
Yeah, I noticed this when investigating possible causes for the recently found cache invalidation bug. it's conceptually plausible to have that flexibility of an epoch distinct from the state epoch, but in practice was unused.
No description provided.