Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reorder ssz #1099

Merged
merged 2 commits into from
Jun 3, 2020
Merged

reorder ssz #1099

merged 2 commits into from
Jun 3, 2020

Conversation

arnetheduck
Copy link
Member

  • split into hash_trees and ssz_serialization, roughly, for hashing and
    IO
  • move bitseqs into ssz (from stew)
  • clean up imports

zah
zah reviewed Jun 3, 2020
View reviewed changes
beacon_chain/ssz/ssz_serialization.nim Show resolved Hide resolved
beacon_chain/ssz/types.nim
serialization/[object_serialization, errors],
./spec_types, ./bitseqs,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The types module should export bitseqs IMO. I've noticed few places where you had to include both.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

part of my reasoning for splitting out HTR was pretty similar

@arnetheduck
reorder ssz
9a254e3 
* split into hash_trees and ssz_serialization, roughly, for hashing and
IO
* move bitseqs into ssz (from stew)
* clean up imports
@arnetheduck arnetheduck merged commit 56ffb69 into devel Jun 3, 2020
@arnetheduck arnetheduck deleted the ssz-reorder branch June 3, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zah zah zah left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arnetheduck @zah