Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uint256 fuzz test vs TTMath #34

Merged
merged 4 commits into from
May 3, 2018
Merged

Conversation

mratsim
Copy link
Contributor

@mratsim mratsim commented May 3, 2018

This adds fuzz testing vs TTMath.

It requires the latest Nimbus patch: status-im/Nim@60db1a8

There is still a C++ only SIGSEGV with nil string/json (?):

<...>/.nimble/pkgs/quicktest-0.18.0/quicktest.nim(414, 47) Hint: simpleGetOrDefault(parseJson(serialized397017), "args") --> 'getOrDefault(parseJson(serialized397017), "args")' [Pattern]
SIGSEGV: Illegal storage access. (Attempt to read from nil?)

Also unfortunately, to add this to CI, Stint must require quicktest and ttmath, though if they are not used it shouldn't force C++ compilation. Feature request here: nim-lang/nimble#482.

@mratsim mratsim merged commit 4c055e4 into master May 3, 2018
@mratsim mratsim deleted the Add-uint256-fuzz-test-vs-ttmath branch May 8, 2018 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants