Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add native nim mode #142

Merged
merged 2 commits into from
Sep 25, 2023
Merged

add native nim mode #142

merged 2 commits into from
Sep 25, 2023

Conversation

arnetheduck
Copy link
Member

No description provided.

mratsim
mratsim reviewed Sep 21, 2023
View reviewed changes
Copy link
Contributor

@mratsim mratsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM however you might want to test that mode in CI, maybe even by compiling to wasm and run wasm tests in CI?

@arnetheduck
Copy link
Member Author

compiling to wasm and run wasm tests in CI?

I don't think we have a good role model for that yet, ie only ad-hoc experiments (which this support also is) - when the time comes, we would probably add it across the board

@arnetheduck arnetheduck merged commit 711cda4 into master Sep 25, 2023
12 checks passed
@arnetheduck arnetheduck deleted the native-nim branch September 25, 2023 14:49
@mratsim mratsim mentioned this pull request Sep 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mratsim mratsim mratsim left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arnetheduck @mratsim