Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port merkleization off ssz #376

Merged
merged 1 commit into from
Jul 19, 2021
Merged

Conversation

KonradStaniec
Copy link
Contributor

Merkelization of ssz is needed for status-im/nimbus-eth1#756.

There is an effort to port whole ssz to separate library status-im/nim-ssz-serialization#1, but to finish this it would require rethinking design of the library. For now this pr follows suit of the rest of ssz to make progress on fluffy front.

@KonradStaniec KonradStaniec requested a review from kdeme July 19, 2021 10:00
Copy link
Contributor

@kdeme kdeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are sticking with this solution for a while to come, we better add some tests too in the near future

@KonradStaniec
Copy link
Contributor Author

Created separate issue for this - #377

@KonradStaniec KonradStaniec merged commit 44fee39 into master Jul 19, 2021
@KonradStaniec KonradStaniec deleted the feature/port-basic-merkleization branch July 19, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants