Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stale bootstrap nodes will block the bucket for revalidation #280

Open
kdeme opened this issue Jul 13, 2020 · 0 comments
Open

Stale bootstrap nodes will block the bucket for revalidation #280

kdeme opened this issue Jul 13, 2020 · 0 comments
Labels
discoveryv5 Discovery v5 related issues

Comments

@kdeme
Copy link
Contributor

kdeme commented Jul 13, 2020

Bootstrap nodes are currently never removed. Also not when pinging them fails.
The idea is here that they should be highly available (trusted) nodes that one can always fallback to.

However, if a bootstrap node is unreachable (goes stale), then this has the side-effect that it will never be put in front of the bucket and practically block revalidation of all nodes in front of that bucket (until the bucket gets split at least).

Those nodes will still be "tested" for availability by doing lookups (findNode requests) though, so it is not that terrible.

Better solution would be to remove the bootstrap nodes, but always keep them aside as fallback for when the routing table drops to < bootstrapnodes.len peers.

@kdeme kdeme added the discoveryv5 Discovery v5 related issues label Jul 13, 2020
kdeme added a commit that referenced this issue Nov 27, 2020
* Remove also bootstrap nodes if they fail to respond

* Repopulate the routing table (with bootstrap nodes) when the

routing table drops low
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discoveryv5 Discovery v5 related issues
Projects
None yet
Development

No branches or pull requests

1 participant