Cached group checks #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mratsim
force-pushed
the
cached-group-checks
branch
from
fe28063 to
c925b0c
Compare
|
okay so I broke the PR ... I didn't close it ... nor did I merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the new primitives mentioned in #92 for cached group checks.
Now we check at deserialization:
Instead of checking that at verification time. Since public keys are reused multiple time this is a significant performance improvement.
New perf
In #97 we had
So we cumulated a total of (4025212-4588537)/(4588537) = 12.2% perf improvement compared to the current BLST in Nimbus.
Closes #42 as well