Stack corruption due to ECP_mul temporary #43
Comments
|
Adding more details in ECP_mul, it seems like
|
|
Adding some debug shows that it's not the calling convention proc `$`*(a: BIG_384): string
proc mul*(a: var ECP_BLS381, b: BIG_384) {.inline.} =
## Multiply point ``a`` by big integer ``b``.
{.noSideEffect.}:
debugEcho "common.mul b: ", $b
ECP_BLS381_mul(addr a, b)
|
|
So the garbage at the beginning may be hidden due to
|
|
Replacing iterator validatorKeys*(conf: BeaconNodeConf): ValidatorPrivKey =
for validatorKeyFile in conf.validators:
try:
yield validatorKeyFile.load
except CatchableError as err:
warn "Failed to load validator private key",
file = validatorKeyFile.string, err = err.msg
for kind, file in walkDir(conf.localValidatorsDir):
if kind in {pcFile, pcLinkToFile} and
cmpIgnoreCase(".privkey", splitFile(file).ext) == 0:
try:
yield ValidatorPrivKey.init(readFile(file).string)
except CatchableError as err:
warn "Failed to load a validator private key", file, err = err.msgby iterator validatorKeys*(conf: BeaconNodeConf): ValidatorPrivKey =
for validatorKeyFile in conf.validators:
try:
yield validatorKeyFile.load
except CatchableError as err:
warn "Failed to load validator private key",
file = validatorKeyFile.string, err = err.msg
for kind, file in walkDir(conf.localValidatorsDir):
if kind in {pcFile, pcLinkToFile} and
cmpIgnoreCase(".privkey", splitFile(file).ext) == 0:
try:
let privkey = ValidatorPrivKey.init(readFile(file).string)
debugEcho "iter: ", cast[array[7, uint64]](privkey)
except CatchableError as err:
warn "Failed to load a validator private key", file, err = err.msgsolves the issue |
This was referenced Mar 12, 2020
|
Existing data was properly overwritten if the input bytes/string was lengthy enough. This is fixed in #44, calling |
mratsim
added a commit
to status-im/nimbus-eth2
that referenced
this issue
Mar 12, 2020
tersec
pushed a commit
to status-im/nimbus-eth2
that referenced
this issue
Mar 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A followup on #40 and another debugging session on status-im/nimbus-eth2#780
By instrumenting privToPub and ECP_MUL with
We get the following stacktrace after building beacon_node with
Trying to isolate this with the following test cases gives different result
Notice that the temporary variable
tfirst bits are not polluted.The text was updated successfully, but these errors were encountered: