Update to use embark 6.0.0 #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0kok0
reviewed
Jun 26, 2020
| }, | ||
| "options": { | ||
| "solc": { | ||
| "optimize": true, |
embark.json
Outdated
| "web3": "1.0.0-beta.34", | ||
| "solc": "0.4.24", | ||
| "web3": "1.0.0-beta", | ||
| "solc": "0.5.4", |
There was a problem hiding this comment.
You probably have a good reason to use .5.4 here right?
|
|
||
| require(v == 27 || v == 28); | ||
| if (v < 27) { | ||
| v += 27; |
0kok0
reviewed
Jun 26, 2020
| bytes4 constant NAME_INTERFACE_ID = 0x691f3431; | ||
| bytes4 constant ABI_INTERFACE_ID = 0x2203ab56; | ||
| bytes4 constant PUBKEY_INTERFACE_ID = 0xc8690233; | ||
| bytes4 constant TEXT_INTERFACE_ID = 0x59d1d43c; | ||
| bytes4 constant MULTIHASH_INTERFACE_ID = 0xe89401a1; | ||
| bytes4 constant CONTENTHASH_INTERFACE_ID = 0xbc1c58d1; | ||
| bytes4 constant INTERFACE_INTERFACE_ID = bytes4(keccak256("interfaceImplementer(bytes32,bytes4)")); |
There was a problem hiding this comment.
Is there any trouble if there's a collision for this id?
0kok0
approved these changes
Jul 21, 2020
rajeevgopalakrishna
approved these changes
Jul 24, 2020
|
Recording our decision here - as discussed, this PR only changes Embark dependencies. So the Crytic issues reported (all on legacy contracts) for this PR will be carried over for reviewing/resolution to the other PRs after rebasing them to this PR merge. |
corpetty
approved these changes
Jul 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.