Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider renaming CollectibleV1 #46

Closed
0x-r4bbit opened this issue Feb 21, 2024 · 0 comments · Fixed by #51
Closed

Consider renaming CollectibleV1 #46

0x-r4bbit opened this issue Feb 21, 2024 · 0 comments · Fixed by #51
Assignees
@0x-r4bbit
Labels
type: discussion
Milestone
Communities Contr...

Comments

@0x-r4bbit
Copy link
Member

I think the contract name has had its purpose, but we should probably give it something a bit more "version agnostic".
We have a CommunityERC20 in this repository, which is an ERC20 plus CommunityOwnable capabilities.

CollectibleV1 is an ERC721 with CommunityOwnable capabilities.

How about renaming CollectibleV1 to CommunityERC721?

Thoughts @gravityblast ?
@0x-r4bbit 0x-r4bbit self-assigned this Feb 23, 2024
0x-r4bbit added a commit that referenced this issue Feb 23, 2024
@0x-r4bbit
refactor!: rename CollectibleV1to CommunityERC721
7a8e52d 
As discussed in #46, `CollectibleV1` is not a good name for this
contract as we don't want versioning in the naming. To align with other
contracts in this repository, we're renaming this contract to
`CommunityERC721`.

BREAKING CHANGE: Any references to `CollectibleV1` must be replaced with
`CommunityERC721`

Closes #46
@0x-r4bbit 0x-r4bbit mentioned this issue Feb 23, 2024
Merged
5 tasks
0x-r4bbit added a commit that referenced this issue Feb 26, 2024
@0x-r4bbit
refactor!: rename CollectibleV1to CommunityERC721
88ea9e9 
As discussed in #46, `CollectibleV1` is not a good name for this
contract as we don't want versioning in the naming. To align with other
contracts in this repository, we're renaming this contract to
`CommunityERC721`.

BREAKING CHANGE: Any references to `CollectibleV1` must be replaced with
`CommunityERC721`

Closes #46
0x-r4bbit added a commit that referenced this issue Feb 26, 2024
@0x-r4bbit
refactor!: rename CollectibleV1to CommunityERC721
82a94d6 
As discussed in #46, `CollectibleV1` is not a good name for this
contract as we don't want versioning in the naming. To align with other
contracts in this repository, we're renaming this contract to
`CommunityERC721`.

BREAKING CHANGE: Any references to `CollectibleV1` must be replaced with
`CommunityERC721`

Closes #46
0x-r4bbit added a commit that referenced this issue Feb 27, 2024
@0x-r4bbit
refactor!: rename CollectibleV1to CommunityERC721
a84c46b 
As discussed in #46, `CollectibleV1` is not a good name for this
contract as we don't want versioning in the naming. To align with other
contracts in this repository, we're renaming this contract to
`CommunityERC721`.

BREAKING CHANGE: Any references to `CollectibleV1` must be replaced with
`CommunityERC721`

Closes #46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0x-r4bbit 0x-r4bbit

Labels
type: discussion
Projects
None yet
Milestone
Communities Contracts - Maintenance
Development

Successfully merging a pull request may close this issue.

refactor!: rename CollectibleV1to CommunityERC721 status-im/communities-contracts
1 participant
@0x-r4bbit