refactor!: Chi: Use u64 for freedom
#306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Degrees of freedom `k` is usually defined as a positive integer. Storing `k` as a NonZeroU64 avoids all degenerate cases from the start (k < 0, k == 0, k == NaN), and the overhead of casting to an f64 for some operations should be minimal. NonZeroU64 also allows memory layout optimizations (similar to the nullptr optimization).
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #306 +/- ##
==========================================
- Coverage 93.73% 93.70% -0.04%
==========================================
Files 53 53
Lines 12010 11939 -71
==========================================
- Hits 11258 11187 -71
Misses 752 752 ☔ View full report in Codecov by Sentry. |
|
Statically is a great way to remove those cases, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all degenerate cases for
Chi(see #102).Degrees of freedom
kis usually defined as a positive integer. Storingkas a NonZeroU64 avoids all degenerate cases from the start (k < 0, k == 0, k == NaN), and the overhead of casting to an f64 for some operations should be minimal.NonZeroU64 also allows memory layout optimizations (similar to the nullptr optimization). E.g.
std::mem::size_of::<Result<Chi, ChiError>>()is now== 8, when before it was greater than 8.Also removed all tests that used k = 0, k = NaN, k = +/- INF and other non-integer k (e.g. k == 2.5)