refactor: Categorical now stores normalized values for cdf and sf #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norm_pmf (probabilities) was already normalized before storing, but cdf and sf weren't. Instead, they were normalized on every API call. The refactor also reduces the amount of vec/slice iterations in `new` from 4 to 2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(De)normalization needs to be done on every cdf- or sf-related API call at the moment. It's much simpler to handle it like the pmf vector and just do it once in
new.This breaks multinomial because it uses some of the
Categoricalhelper functions in its implementation. This PR depends on another one resolving this, e.g. #287.