Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/multivariate dimension generic #253

Merged

Conversation

YeungOnion
Copy link
Contributor

extending API changes introduced in #209 / #252 for Multinomial and Dirichlet. Also modifies / reintroduces tests for these distributions. Test values were compared to hand calculations, perhaps I should compare to scipy?

@YeungOnion YeungOnion force-pushed the feat/multivariate-dimension-generic branch from 463b487 to 977e120 Compare August 16, 2024 04:32
@YeungOnion YeungOnion force-pushed the feat/multivariate-dimension-generic branch from 977e120 to 4e3f09a Compare August 16, 2024 05:12
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 89.09091% with 12 lines in your changes missing coverage. Please review.

Project coverage is 89.70%. Comparing base (4f362c6) to head (4e3f09a).
Report is 1 commits behind head on master.

Files Patch % Lines
src/distribution/dirichlet.rs 89.09% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #253      +/-   ##
==========================================
+ Coverage   89.67%   89.70%   +0.03%     
==========================================
  Files          49       49              
  Lines       10989    11031      +42     
==========================================
+ Hits         9854     9895      +41     
- Misses       1135     1136       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YeungOnion YeungOnion merged commit a239ebe into statrs-dev:master Aug 16, 2024
7 of 8 checks passed
@YeungOnion YeungOnion deleted the feat/multivariate-dimension-generic branch August 16, 2024 05:22
@YeungOnion YeungOnion restored the feat/multivariate-dimension-generic branch August 16, 2024 05:23
@YeungOnion YeungOnion linked an issue Sep 6, 2024 that may be closed by this pull request
@YeungOnion YeungOnion added this to the 0.18 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update Dirichlet to nalgebra multivariate
1 participant