Fix fisher test #250
Merged
Fix fisher test #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YeungOnion
force-pushed
the
fix-fisher-test
branch
2 times, most recently
from
e788de5 to
56eb7a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#167 introduced fisher exact tests
This adds some minor docs, most notably, specifying that the expected table, provided as a slice of floats (i.e. flat), is row-major.
Also fixes a "bug" for short circuiting the evaluation of the test when both values in either row are 0's. Full evaluation is exactly "1.0f64" as well, but pushing for consistency here.