-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fisher exact #167
Merged
Merged
Add fisher exact #167
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,358 @@ | ||
use crate::distribution::{Discrete, DiscreteCDF, Hypergeometric}; | ||
use crate::StatsError; | ||
|
||
#[derive(Debug, Copy, Clone)] | ||
pub enum Alternative { | ||
TwoSided, | ||
Less, | ||
Greater, | ||
} | ||
|
||
const EPSILON: f64 = 1.0 - 1e-4; | ||
|
||
/// Binary search in two-sided test with starting bound as argument | ||
fn binary_search( | ||
n: u64, | ||
n1: u64, | ||
n2: u64, | ||
mode: u64, | ||
p_exact: f64, | ||
epsilon: f64, | ||
upper: bool, | ||
) -> u64 { | ||
let (mut min_val, mut max_val) = { | ||
if upper { | ||
(mode, n) | ||
} else { | ||
(0, mode) | ||
} | ||
}; | ||
|
||
let population = n1 + n2; | ||
let successes = n1; | ||
let draws = n; | ||
let dist = Hypergeometric::new(population, successes, draws).unwrap(); | ||
|
||
let mut guess = 0; | ||
loop { | ||
if max_val - min_val <= 1 { | ||
break; | ||
} | ||
guess = { | ||
if max_val == min_val + 1 && guess == min_val { | ||
max_val | ||
} else { | ||
(max_val + min_val) / 2 | ||
} | ||
}; | ||
|
||
let ng = { | ||
if upper { | ||
guess - 1 | ||
} else { | ||
guess + 1 | ||
} | ||
}; | ||
|
||
let pmf_comp = dist.pmf(ng); | ||
let p_guess = dist.pmf(guess); | ||
if p_guess <= p_exact && p_exact < pmf_comp { | ||
break; | ||
} | ||
if p_guess < p_exact { | ||
max_val = guess | ||
} else { | ||
min_val = guess | ||
} | ||
} | ||
|
||
if guess == 0 { | ||
guess = min_val | ||
} | ||
if upper { | ||
loop { | ||
if guess > 0 && dist.pmf(guess) < p_exact * epsilon { | ||
guess -= 1; | ||
} else { | ||
break; | ||
} | ||
} | ||
loop { | ||
if dist.pmf(guess) > p_exact / epsilon { | ||
guess += 1; | ||
} else { | ||
break; | ||
} | ||
} | ||
} else { | ||
loop { | ||
if dist.pmf(guess) < p_exact * epsilon { | ||
guess += 1; | ||
} else { | ||
break; | ||
} | ||
} | ||
loop { | ||
if guess > 0 && dist.pmf(guess) > p_exact / epsilon { | ||
guess -= 1; | ||
} else { | ||
break; | ||
} | ||
} | ||
} | ||
guess | ||
} | ||
|
||
/// Perform a Fisher exact test on a 2x2 contingency table. | ||
/// Based on scipy's fisher test: https://docs.scipy.org/doc/scipy/reference/generated/scipy.stats.fisher_exact.html#scipy-stats-fisher-exact | ||
/// Returns the odds ratio and p_value | ||
/// # Examples | ||
/// | ||
/// ``` | ||
/// use statrs::statis_tests::fishers_exact; | ||
/// use statrs::statis_tests::Alternative; | ||
/// let table = [3, 5, 4, 50]; | ||
/// let (odds_ratio, p_value) = fishers_exact_with_odds_ratio(&table, Alternative::Less).unwrap(); | ||
/// ``` | ||
pub fn fishers_exact_with_odds_ratio( | ||
table: &[u64; 4], | ||
alternative: Alternative, | ||
) -> Result<(f64, f64), StatsError> { | ||
// Calculate fisher's exact test with the odds ratio | ||
if (table[0] == 0 && table[2] == 0) || (table[1] == 0 && table[3] == 0) { | ||
// If both values in a row or column are zero, p-value is 1 and odds ratio is NaN. | ||
return Ok((f64::NAN, 1.0)); | ||
} | ||
|
||
let odds_ratio = { | ||
if table[1] > 0 && table[2] > 0 { | ||
(table[0] * table[3]) as f64 / (table[1] * table[2]) as f64 | ||
} else { | ||
f64::INFINITY | ||
} | ||
}; | ||
|
||
let p_value = fishers_exact(table, alternative)?; | ||
Ok((odds_ratio, p_value)) | ||
} | ||
|
||
/// Perform a Fisher exact test on a 2x2 contingency table. | ||
/// Based on scipy's fisher test: https://docs.scipy.org/doc/scipy/reference/generated/scipy.stats.fisher_exact.html#scipy-stats-fisher-exact | ||
/// Returns only the p_value | ||
/// # Examples | ||
/// | ||
/// ``` | ||
/// use statrs::statis_tests::fishers_exact; | ||
/// use statrs::statis_tests::Alternative; | ||
/// let table = [3, 5, 4, 50]; | ||
/// let p_value = fishers_exact(&table, Alternative::Less).unwrap(); | ||
/// ``` | ||
pub fn fishers_exact(table: &[u64; 4], alternative: Alternative) -> Result<f64, StatsError> { | ||
// If both values in a row or column are zero, the p-value is 1 and the odds ratio is NaN. | ||
if (table[0] == 0 && table[2] == 0) || (table[1] == 0 && table[3] == 0) { | ||
return Ok(1.0); | ||
} | ||
|
||
let n1 = table[0] + table[1]; | ||
let n2 = table[2] + table[3]; | ||
let n = table[0] + table[2]; | ||
|
||
let p_value = { | ||
let population = n1 + n2; | ||
let successes = n1; | ||
|
||
match alternative { | ||
Alternative::Less => { | ||
let draws = n; | ||
let dist = Hypergeometric::new(population, successes, draws)?; | ||
dist.cdf(table[0]) | ||
} | ||
Alternative::Greater => { | ||
let draws = table[1] + table[3]; | ||
let dist = Hypergeometric::new(population, successes, draws)?; | ||
dist.cdf(table[1]) | ||
} | ||
Alternative::TwoSided => { | ||
let draws = n; | ||
let dist = Hypergeometric::new(population, successes, draws)?; | ||
|
||
let p_exact = dist.pmf(table[0]); | ||
let mode = ((n + 1) * (n1 + 1)) / (n1 + n2 + 2); | ||
let p_mode = dist.pmf(mode); | ||
|
||
if (p_exact - p_mode).abs() / p_exact.max(p_mode) <= 1.0 - EPSILON { | ||
return Ok(1.0); | ||
} | ||
|
||
if table[0] < mode { | ||
let p_lower = dist.cdf(table[0]); | ||
if dist.pmf(n) > p_exact / EPSILON { | ||
return Ok(p_lower); | ||
} | ||
let guess = binary_search(n, n1, n2, mode, p_exact, EPSILON, true); | ||
return Ok(p_lower + 1.0 - dist.cdf(guess - 1)); | ||
} | ||
|
||
let p_upper = 1.0 - dist.cdf(table[0] - 1); | ||
if dist.pmf(0) > p_exact / EPSILON { | ||
return Ok(p_upper); | ||
} | ||
|
||
let guess = binary_search(n, n1, n2, mode, p_exact, EPSILON, false); | ||
p_upper + dist.cdf(guess) | ||
} | ||
} | ||
}; | ||
|
||
Ok(p_value.min(1.0)) | ||
} | ||
|
||
#[cfg(test)] | ||
mod tests { | ||
use super::fishers_exact; | ||
use crate::prec; | ||
use crate::stats_tests::fisher::{fishers_exact_with_odds_ratio, Alternative}; | ||
|
||
/// Test fishers_exact by comparing against values from scipy. | ||
#[test] | ||
fn test_fishers_exact() { | ||
let cases = [ | ||
( | ||
[3, 5, 4, 50], | ||
0.9963034765672599, | ||
0.03970749246529277, | ||
0.03970749246529276, | ||
), | ||
( | ||
[61, 118, 2, 1], | ||
0.27535061623455315, | ||
0.9598172545684959, | ||
0.27535061623455315, | ||
), | ||
( | ||
[172, 46, 90, 127], | ||
1.0, | ||
6.662405187351769e-16, | ||
9.041009036528785e-16, | ||
), | ||
( | ||
[127, 38, 112, 43], | ||
0.8637599357870167, | ||
0.20040942958644145, | ||
0.3687862842650179, | ||
), | ||
( | ||
[186, 177, 111, 154], | ||
0.9918518696328176, | ||
0.012550663906725129, | ||
0.023439141644624434, | ||
), | ||
( | ||
[137, 49, 135, 183], | ||
0.999999999998533, | ||
5.6517533666400615e-12, | ||
8.870999836202932e-12, | ||
), | ||
( | ||
[37, 115, 37, 152], | ||
0.8834621182590621, | ||
0.17638403366123565, | ||
0.29400927608021704, | ||
), | ||
( | ||
[124, 117, 119, 175], | ||
0.9956704915461392, | ||
0.007134712391455461, | ||
0.011588218284387445, | ||
), | ||
( | ||
[70, 114, 41, 118], | ||
0.9945558498544903, | ||
0.010384865876586255, | ||
0.020438291037108678, | ||
), | ||
( | ||
[173, 21, 89, 7], | ||
0.2303739114068352, | ||
0.8808002774812677, | ||
0.4027047267306024, | ||
), | ||
( | ||
[18, 147, 123, 58], | ||
4.077820702304103e-29, | ||
0.9999999999999817, | ||
0.0, | ||
), | ||
( | ||
[116, 20, 92, 186], | ||
0.9999999999998267, | ||
6.598118571034892e-25, | ||
8.164831402188242e-25, | ||
), | ||
( | ||
[9, 22, 44, 38], | ||
0.01584272038710196, | ||
0.9951463496539362, | ||
0.021581786662999272, | ||
), | ||
( | ||
[9, 101, 135, 7], | ||
3.3336213533847776e-50, | ||
1.0, | ||
3.3336213533847776e-50, | ||
), | ||
( | ||
[153, 27, 191, 144], | ||
0.9999999999950817, | ||
2.473736787266208e-11, | ||
3.185816623300107e-11, | ||
), | ||
( | ||
[111, 195, 189, 69], | ||
6.665245982898848e-19, | ||
0.9999999999994574, | ||
1.0735744915712542e-18, | ||
), | ||
( | ||
[125, 21, 31, 131], | ||
0.99999999999974, | ||
9.720661317939016e-34, | ||
1.0352129312860277e-33, | ||
), | ||
( | ||
[201, 192, 69, 179], | ||
0.9999999988714893, | ||
3.1477232259550017e-09, | ||
4.761075937088169e-09, | ||
), | ||
( | ||
[124, 138, 159, 160], | ||
0.30153826772785475, | ||
0.7538974235759873, | ||
0.5601766196310243, | ||
), | ||
]; | ||
|
||
for (table, less_expected, greater_expected, two_sided_expected) in cases.iter() { | ||
for (alternative, expected) in [ | ||
Alternative::Less, | ||
Alternative::Greater, | ||
Alternative::TwoSided, | ||
] | ||
.iter() | ||
.zip(vec![less_expected, greater_expected, two_sided_expected]) | ||
{ | ||
let p_value = fishers_exact(table, *alternative).unwrap(); | ||
assert!(prec::almost_eq(p_value, *expected, 1e-12)); | ||
} | ||
} | ||
} | ||
#[test] | ||
fn test_fishers_exact_with_odds() { | ||
let table = [3, 5, 4, 50]; | ||
let (odds_ratio, p_value) = | ||
fishers_exact_with_odds_ratio(&table, Alternative::Less).unwrap(); | ||
assert!(prec::almost_eq(p_value, 0.9963034765672599, 1e-12)); | ||
assert!(prec::almost_eq(odds_ratio, 7.5, 1e-1)); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
pub mod fisher; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A brief docstring on this enum would be nice for our docs.rs, but I don't think one is needed for each of the variants.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approved your PR into this branch with your changes, thank you!