feat(cli): make regexp for excluded namespace configurable #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikgb
force-pushed
the
refactor-out-exclude
branch
from
e22bffa to
0a652eb
Compare
erikgb
force-pushed
the
refactor-out-exclude
branch
2 times, most recently
from
ce48130 to
f7245a4
Compare
erikgb
force-pushed
the
refactor-out-exclude
branch
3 times, most recently
from
65bd783 to
2e16a2c
Compare
erikgb
changed the title
bendikp
reviewed
Jan 26, 2023
erikgb
force-pushed
the
refactor-out-exclude
branch
from
7086953 to
697730e
Compare
erikgb
force-pushed
the
refactor-out-exclude
branch
from
697730e to
abfab72
Compare
bendikp
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the regexp for excluding namespaces from scanning, typically system namespaces, configurable. While this feature might be useful for some, the plan is to add an equivalent configurable property for namespaces to include. And this will allow us to avoid scanning anything other than the workload images under test in our e2e-tests.