Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Ruff D102 & D101 in tests #43

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Ignore Ruff D102 & D101 in tests #43

merged 2 commits into from
Jan 15, 2024

Conversation

mallport
Copy link

@mallport mallport commented Jan 11, 2024

When creating test classes in tests, documenting the class methods and the class itself is overkill. Same principle as the other "D1xx" cases we ignore.

Cases are documented here:
D102: https://docs.astral.sh/ruff/rules/undocumented-public-method/
D101: https://docs.astral.sh/ruff/rules/undocumented-public-class/

@mallport mallport requested a review from arneso-ssb January 11, 2024 15:30
@mallport mallport changed the title Ignore Ruff D102 in tests Ignore Ruff D102 & D101 in tests Jan 11, 2024
Copy link
Member

@arneso-ssb arneso-ssb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree on not require docstring in tests.

@mallport mallport merged commit 7552dcf into main Jan 15, 2024
7 checks passed
@mallport mallport deleted the add-ruff-ignore-tests branch January 15, 2024 08:56
@arneso-ssb arneso-ssb mentioned this pull request Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants